user/sven/git.git/Documentation/CodingGuidelines, branch v1.7.3.5

CodingGuidelines: mention whitespace preferences for shell scripts

2010-12-03T23:22:59Z

Signed-off-by: Giuseppe Bilotta Signed-off-by: Junio C Hamano

CodingGuidelines: reword parameter expansion section

2010-10-13T18:15:14Z

Group entries related to parameter substitutions together and avoid using the word "regexp" to refer to the ${parameter/pattern/string} substitution (banned), as the pattern there is a shell glob and not a regular expression. Signed-off-by: Junio C Hamano

CodingGuidelines: spell Arithmetic Expansion with $(($var))

2010-09-27T17:45:29Z

POSIX wants shells to support both "N" and "$N" and requires them to yield the same answer to $((N)) and $(($N)), but we should aim for portability in a case like this, especially when the price we pay to do so is so small, i.e. a few extra dollars. Signed-off-by: Junio C Hamano

lstat_cache(): swap func(length, string) into func(string, length)

2009-02-10T04:59:26Z

Swap function argument pair (length, string) into (string, length) to conform with the commonly used order inside the GIT source code. Also, add a note about this fact into the coding guidelines. Signed-off-by: Kjetil Barvik Signed-off-by: Junio C Hamano

Mention "local convention" rule in the CodingGuidelines

2009-01-26T08:35:58Z

The document suggests to imitate the existing code, but didn't say which existing code it should imitate. This clarifies. Signed-off-by: しらいしななこ Signed-off-by: Junio C Hamano

Rename path_list to string_list

2008-07-22T02:11:50Z

The name path_list was correct for the first usage of that data structure, but it really is a general-purpose string list. $ perl -i -pe 's/path-list/string-list/g' $(git grep -l path-list) $ perl -i -pe 's/path_list/string_list/g' $(git grep -l path_list) $ git mv path-list.h string-list.h $ git mv path-list.c string-list.c $ perl -i -pe 's/has_path/has_string/g' $(git grep -l has_path) $ perl -i -pe 's/path/string/g' string-list.[ch] $ git mv Documentation/technical/api-path-list.txt \ Documentation/technical/api-string-list.txt $ perl -i -pe 's/strdup_paths/strdup_strings/g' $(git grep -l strdup_paths) ... and then fix all users of string-list to access the member "string" instead of "path". Documentation/technical/api-string-list.txt needed some rewrapping, too. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano

CodingGuidelines: Add a note to avoid assignments inside if()

2008-05-25T05:13:19Z

Signed-off-by: Miklos Vajna Signed-off-by: Junio C Hamano

CodingGuidelines: spell out how we use grep in our scripts

2008-03-02T02:18:16Z

Our scripts try to stick to fairly limited subset of POSIX BRE for portability. It is unclear from manual page from GNU grep which is GNU extension and which is portable, so let's spell it out to help new people to keep their contributions from hurting porters. Signed-off-by: Junio C Hamano

Add Documentation/CodingGuidelines

2007-11-08T01:05:53Z

Even if our code is quite a good documentation for our coding style, some people seem to prefer a document describing it. The part about the shell scripts is clearly just copied from one of Junio's helpful mails, and some parts were added from comments by Junio, Andreas Ericsson and Robin Rosenberg. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano