user/sven/git.git/commit.c, branch v1.5.6.4

Remove unused code in parse_commit_buffer()

2008-06-08T20:46:37Z

The n_refs variable is no longer really used in this function, so there is no reason to keep it. It was introduced in 27dedf0c and the code that really used it was removed in 7914053. Signed-off-by: Miklos Vajna Signed-off-by: Junio C Hamano

builtin-fsck: reports missing parent commits

2008-02-26T07:57:35Z

parse_commit ignores parent commits with certain errors (eg. a non commit object is already loaded under the sha1 of the parent). To make fsck reports such errors, it has to compare the nummer of parent commits returned by parse commit with the number of parent commits in the object or in the graft/shallow file. Signed-off-by: Martin Koegler Signed-off-by: Junio C Hamano

Remove unused object-ref code

2008-02-26T07:57:35Z

Signed-off-by: Martin Koegler Signed-off-by: Junio C Hamano

check return value from parse_commit() in various functions

2008-02-19T04:49:13Z

Signed-off-by: Martin Koegler Signed-off-by: Junio C Hamano

parse_commit: don't fail, if object is NULL

2008-02-19T03:25:26Z

Some codepaths (eg. builtin-rev-parse -> get_merge_bases -> parse_commit) can pass NULL. Signed-off-by: Martin Koegler Signed-off-by: Junio C Hamano

check results of parse_commit in merge_bases

2008-02-19T03:25:26Z

An error is signaled by returning NULL. Signed-off-by: Martin Koegler Signed-off-by: Junio C Hamano

parse_commit_buffer: tighten checks while parsing

2008-01-20T19:00:57Z

This tightens the parsing of a commit object in a couple of ways. - The "tree " header must end with a LF (earlier we did not check this condition). - Make sure parsing of timestamp on the "committer " header does not go beyond the buffer, even when (1) the "author " header does not end with a LF (this means that the commit object is malformed and lacks the committer information) or (2) the "committer " header does not have ">" that is the end of the e-mail address, or (3) the "committer " header does not end with a LF. We however still keep the existing behaviour to return a parsed commit object even when non-structural headers such as committer and author are malformed, so that tools that need to look at commits to clean up a history with such broken commits can still get at the structural data (i.e. the parents chain and the tree object). Signed-off-by: Martin Koegler Signed-off-by: Junio C Hamano

Merge branch 'lt/rev-list-interactive'

2007-11-19T00:03:24Z

* lt/rev-list-interactive: Fix parent rewriting in --early-output revision walker: mini clean-up Enhance --early-output format Add "--early-output" log flag for interactive GUI use Simplify topo-sort logic

Split off the pretty print stuff into its own file

2007-11-05T19:52:14Z

The file commit.c got quite large, but it does not have to be: the code concerning pretty printing is pretty well contained. In fact, this commit just splits it off into pretty.c, leaving commit.c with just 672 lines. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano

Simplify topo-sort logic

2007-11-04T08:54:20Z

.. by not using quite so much indirection. This currently grows the "struct commit" a bit, which could be avoided by using a union for "util" and "indegree" (the topo-sort used to use "util" anyway, so you cannot use them together), but for now the goal of this was to simplify, not optimize. Signed-off-by: Linus Torvalds