user/sven/git.git/entry.c, branch v2.7.0-rc2

entry.c: convert strcpy to xsnprintf

2015-09-25T17:18:18Z

This particular conversion is non-obvious, because nobody has passed our function the length of the destination buffer. However, the interface to checkout_entry specifies that the buffer must be at least TEMPORARY_FILENAME_LENGTH bytes long, so we can check that (meaning the existing code was not buggy, but merely worrisome to somebody reading it). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

read-cache: mark updated entries for split index

2014-06-13T18:49:40Z

The large part of this patch just follows CE_ENTRY_CHANGED marks. replace_index_entry() is updated to update split_index->base->cache[] as well so base->cache[] does not reference to a freed entry. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

entry.c: update cache_changed if refresh_cache is set in checkout_entry()

2014-06-13T18:49:39Z

Other fill_stat_cache_info() is on new entries, which should set CE_ENTRY_ADDED in cache_changed, so we're safe. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

Merge branch 'mh/remove-subtree-long-pathname-fix'

2014-03-25T18:07:09Z

* mh/remove-subtree-long-pathname-fix: entry.c: fix possible buffer overflow in remove_subtree() checkout_entry(): use the strbuf throughout the function

entry.c: fix possible buffer overflow in remove_subtree()

2014-03-13T17:57:48Z

remove_subtree() manipulated path in a fixed-size buffer even though the length of the input, let alone the length of entries within the directory, were not known in advance. Change the function to take a strbuf argument and use that object as its scratch space. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

checkout_entry(): use the strbuf throughout the function

2014-03-13T17:56:50Z

There is no need to break out the "buf" and "len" members into separate temporary variables. Rename path_buf to path and use path.buf and path.len directly. This makes it easier to reason about the data flow in the function. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

checkout_entry(): clarify the use of topath[] parameter

2013-10-24T21:59:39Z

The said function has this signature: extern int checkout_entry(struct cache_entry *ce, const struct checkout *state, char *topath); At first glance, it might appear that the caller of checkout_entry() can specify to which path the contents are written out by the last parameter, and it is tempting to add "const" in front of its type. In reality, however, topath[] is to point at a buffer to store the temporary path generated by the callchain originating from this function, and the temporary path is always short, much shorter than the buffer prepared by its only caller in builtin/checkout-index.c. Document the code a bit to clarify so that future callers know how to use the function better. Noticed-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

entry.c: convert checkout_entry to use strbuf

2013-10-24T21:58:37Z

The old code does not do boundary check so any paths longer than PATH_MAX can cause buffer overflow. Replace it with strbuf to handle paths of arbitrary length. The OS may reject if the path is too long though. But in that case we report the cause (e.g. name too long) and usually move on to checking out the next entry. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

Merge branch 'nd/const-struct-cache-entry'

2013-07-22T18:24:01Z

* nd/const-struct-cache-entry: Convert "struct cache_entry *" to "const ..." wherever possible

apply, entry: speak of submodules instead of subprojects

2013-07-18T17:56:06Z

There are only four (with some generous rounding) instances in the current source code where we speak of "subproject" instead of "submodule". They are as follows: * one error message in git-apply and two in entry.c * the patch format for submodule changes The latter was introduced in 0478675 (Expose subprojects as special files to "git diff" machinery, 2007-04-15), apparently before the terminology was settled. We can of course not change the patch format. Let's at least change the error messages to consistently call them "submodule". Signed-off-by: Thomas Rast Reviewed-by: Jonathan Nieder Signed-off-by: Junio C Hamano