user/sven/git.git/exec_cmd.c, branch v1.4.1.1

git_exec_path, execv_git_cmd: ignore empty environment variables

2006-05-31T04:49:01Z

Ignoring empty environment variables is good common practice. Ignoring --exec-path with empty argument won't harm, too: if user means current directory, there is a "--exec-path=." Signed-off-by: Dmitry V. Levin Signed-off-by: Junio C Hamano

execv_git_cmd: Fix stack buffer overflow.

2006-05-31T04:47:29Z

Signed-off-by: Dmitry V. Levin Signed-off-by: Junio C Hamano

cleanups: remove unused variable from exec_cmd.c

2006-04-17T22:06:40Z

Not sure whether it should be removed, or whether execv_git_cmd() should return it rather than -1 at bottom. Signed-off-by: Serge E. Hallyn Signed-off-by: Junio C Hamano

Use #define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))

2006-03-09T19:58:05Z

Signed-off-by: Junio C Hamano

Const tightening.

2006-03-05T10:47:29Z

Mark Wooding noticed there was a type mismatch warning in git.c; this patch does things slightly differently (mostly tightening const) and was what I was holding onto, waiting for the setup-revisions change to be merged into the master branch. Signed-off-by: Junio C Hamano

Use setenv(), fix warnings

2006-02-26T23:06:45Z

- Fix -Wundef -Wold-style-definition warnings - Make pll_free() static [jc: original patch by Timo had another unrelated bits: - Use setenv() instead of putenv() I'm postponing that part for now.] Signed-off-by: Timo Hirvonen Signed-off-by: Junio C Hamano

Exec git programs without using PATH.

2006-01-14T00:49:01Z

The git suite may not be in PATH (and thus programs such as git-send-pack could not exec git-rev-list). Thus there is a need for logic that will locate these programs. Modifying PATH is not desirable as it result in behavior differing from the user's intentions, as we may end up prepending "/usr/bin" to PATH. - git C programs will use exec*_git_cmd() APIs to exec sub-commands. - exec*_git_cmd() will execute a git program by searching for it in the following directories: 1. --exec-path (as used by "git") 2. The GIT_EXEC_PATH environment variable. 3. $(gitexecdir) as set in Makefile (default value $(bindir)). - git wrapper will modify PATH as before to enable shell scripts to invoke "git-foo" commands. Ideally, shell scripts should use the git wrapper to become independent of PATH, and then modifying PATH will not be necessary. [jc: with minor updates after a brief review.] Signed-off-by: Michal Ostrowski Signed-off-by: Junio C Hamano