user/sven/git.git/exec_cmd.c, branch v1.5.4.4

Trace and quote with argv: get rid of unneeded count argument.

2007-12-04T06:11:53Z

Now that str_buf takes care of all the allocations, there is no more gain to pass an argument count. So this patch removes the "count" argument from: - "sq_quote_argv" - "trace_argv_printf" and all the callers. Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano

use only the $PATH for exec'ing git commands

2007-10-30T03:51:37Z

We need to correctly set up $PATH for non-c based git commands. Since we already do this, we can just use that $PATH and execvp, instead of looping over the paths with execve. This patch adds a setup_path() function to exec_cmd.c, which sets the $PATH order correctly for our search order. execv_git_cmd() is stripped down to setting up argv and calling execvp(). git.c's main() only only needs to call setup_path(). Signed-off-by: Scott R Parish Signed-off-by: Junio C Hamano

"current_exec_path" is a misleading name, use "argv_exec_path"

2007-10-30T03:51:37Z

Signed-off-by: Scott R Parish Signed-off-by: Junio C Hamano

Mechanical conversion to use prefixcmp()

2007-02-21T06:03:15Z

This mechanically converts strncmp() to use prefixcmp(), but only when the parameters match specific patterns, so that they can be verified easily. Leftover from this will be fixed in a separate step, including idiotic conversions like if (!strncmp("foo", arg, 3)) => if (!(-prefixcmp(arg, "foo"))) This was done by using this script in px.perl #!/usr/bin/perl -i.bak -p if (/strncmp$([^,]+), "([^\\"]*)", (\d+)$/ && (length($2) == $3)) { s|strncmp$([^,]+), "([^\\"]*)", (\d+)$|prefixcmp($1, "$2")|; } if (/strncmp$"([^\\"]*)", ([^,]+), (\d+)$/ && (length($1) == $3)) { s|strncmp$"([^\\"]*)", ([^,]+), (\d+)$|(-prefixcmp($2, "$1"))|; } and running: $ git grep -l strncmp -- '*.c' | xargs perl px.perl Signed-off-by: Junio C Hamano

Use preprocessor constants for environment variable names.

2006-12-19T09:51:51Z

We broke the discipline Linus set up to allow compiler help us avoid typos in environment names in the early days of git over time. This defines a handful preprocessor constants for environment variable names used in relatively core parts of the system. I've left out variable names specific to subsystems such as HTTP and SSL as I do not think they are big problems. Signed-off-by: Junio C Hamano

Trace into open fd and refactor tracing code.

2006-08-31T21:16:38Z

Now if GIT_TRACE is set to an integer value greater than 1 and lower than 10, we interpret this as an open fd value and we trace into it. Note that this behavior is not compatible with the previous one. We also trace whole messages using one write(2) call to make sure messages from processes do net get mixed up in the middle. It's now possible to run the tests like this: GIT_TRACE=9 make test 9>/var/tmp/trace.log Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano

remove unnecessary initializations

2006-08-16T04:22:20Z

[jc: I needed to hand merge the changes to the updated codebase, so the result needs to be checked.] Signed-off-by: David Rientjes Signed-off-by: Junio C Hamano

GIT_TRACE: fix a mixed declarations and code warning

2006-07-09T07:57:23Z

Signed-off-by: Timo Hirvonen Signed-off-by: Junio C Hamano

GIT_TRACE: show which built-in/external commands are executed

2006-07-09T07:57:23Z

With the environment variable GIT_TRACE set git will show - alias expansion - built-in command execution - external command execution on stderr. Signed-off-by: Matthias Lederhofer Signed-off-by: Junio C Hamano

git_exec_path, execv_git_cmd: ignore empty environment variables

2006-05-31T04:49:01Z

Ignoring empty environment variables is good common practice. Ignoring --exec-path with empty argument won't harm, too: if user means current directory, there is a "--exec-path=." Signed-off-by: Dmitry V. Levin Signed-off-by: Junio C Hamano