<feed xmlns='http://www.w3.org/2005/Atom'>
<title>user/sven/git.git/git-request-pull.sh, branch v1.7.7.4</title>
<subtitle>Git
</subtitle>
<id>https://git.stealer.net/cgit.cgi/user/sven/git.git/atom?h=v1.7.7.4</id>
<link rel='self' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/atom?h=v1.7.7.4'/>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/'/>
<updated>2011-03-02T20:26:58Z</updated>
<entry>
<title>git-request-pull: open-code the only invocation of get_remote_url</title>
<updated>2011-03-02T20:26:58Z</updated>
<author>
<name>Uwe Kleine-König</name>
<email>u.kleine-koenig@pengutronix.de</email>
</author>
<published>2011-03-01T09:21:37Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=1a92777504afc09e071d7d828e084e6a4dadfce2'/>
<id>urn:sha1:1a92777504afc09e071d7d828e084e6a4dadfce2</id>
<content type='text'>
So sh:get_remote_url can go now and git-request-pull
doesn't need to source git-parse-remote. anymore.

Signed-off-by: Uwe Kleine-König &lt;u.kleine-koenig@pengutronix.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>git-request-pull.sh: remove -e switch to shell interpreter which breaks ksh</title>
<updated>2010-06-02T16:28:12Z</updated>
<author>
<name>Brandon Casey</name>
<email>drafnel@gmail.com</email>
</author>
<published>2010-06-02T00:13:41Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=53dfac44c93d5861f0ab60fc38e1a2d3b67e8c62'/>
<id>urn:sha1:53dfac44c93d5861f0ab60fc38e1a2d3b67e8c62</id>
<content type='text'>
The -e option causes the shell to exit immediately when a command exits
with a non-zero exit status.  This does not seem to cause a problem for
Bash, but it does cause a problem for the Korn shell, like Solaris's
xpg4/sh, whose unset utility returns non-zero if it is passed a variable
name which was not previously set.  When using xpg4/sh, git-request-pull
exits while sourcing git-sh-setup since git-sh-setup tries to unset the
CDPATH environment variable.

When git-request-pull was originally written, it did not do any error
checking and it used this shell feature to exit when an error occurred.
This script now performs proper error checking and provides useful error
messages, so this -e option appears to be merely a historical artifact and
can be removed.

Kudos to Jonathan Nieder for introducing t5150 which exercises the
request-pull code path.

Suggested-by: Brandon Casey &lt;drafnel@gmail.com&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Merge branch 'jn/maint-request-pull' into jn/request-pull</title>
<updated>2010-05-08T04:33:08Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2010-05-08T04:32:56Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=ea0edad58f58378cb42c2895c5578524bbaba296'/>
<id>urn:sha1:ea0edad58f58378cb42c2895c5578524bbaba296</id>
<content type='text'>
</content>
</entry>
<entry>
<title>request-pull: protect against OPTIONS_KEEPDASHDASH from environment</title>
<updated>2010-05-01T18:02:21Z</updated>
<author>
<name>Jonathan Nieder</name>
<email>jrnieder@gmail.com</email>
</author>
<published>2010-04-24T12:15:37Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=50ab6558bf688e15048e189bdaf9174b217e1748'/>
<id>urn:sha1:50ab6558bf688e15048e189bdaf9174b217e1748</id>
<content type='text'>
Like most git commands, request-pull supports a -- delimiter to allow
callers to pass arguments that would otherwise be treated as an option
afterwards.  The internal OPTIONS_KEEPDASHDASH variable is passed
empty to git-sh-setup to indicate that request-pull itself does not
care about the position of the -- delimiter.  But if the user has
that variable in her environment, request-pull will see the “--” and
fail.

Empty it explicitly to guard against this.  While at it, make the
corresponding fix to git-resurrect, too (all other scripts in git.git
already protect themselves).

Acked-by: Thomas Rast &lt;trast@student.ethz.ch&gt;
Acked-by: Miklos Vajna &lt;vmiklos@frugalware.org&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>request-pull: avoid mentioning that the start point is a single commit</title>
<updated>2010-01-30T06:26:39Z</updated>
<author>
<name>Miklos Vajna</name>
<email>vmiklos@frugalware.org</email>
</author>
<published>2010-01-29T14:17:59Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=10eb00073f07e1c40a17327417aa39cc4cc9c254'/>
<id>urn:sha1:10eb00073f07e1c40a17327417aa39cc4cc9c254</id>
<content type='text'>
Previously we ran shortlog on the start commit which always printed
"(1)" after the start commit, which gives no information, but makes the
output less easy to read.  Instead of giving the author name of the
commit, use the space for committer timestamp to help recipient judge
the freshness of the offered branch more easily.

Signed-off-by: Miklos Vajna &lt;vmiklos@frugalware.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>request-pull: optionally show a patch as well</title>
<updated>2009-07-29T18:02:49Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2009-07-27T21:27:47Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=133cfaeb8ba40f12e4c0ad99bdd3a0a4f8d0ade2'/>
<id>urn:sha1:133cfaeb8ba40f12e4c0ad99bdd3a0a4f8d0ade2</id>
<content type='text'>
Allow git request-pull to append diff body into the pull request.

It's useful for small series of commits.

Tested-by: Cyrill Gorcunov &lt;gorcunov@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>request-pull: allow ls-remote to notice remote.$nickname.uploadpack</title>
<updated>2009-07-29T06:31:38Z</updated>
<author>
<name>Tom Grennan</name>
<email>tgrennan@redback.com</email>
</author>
<published>2009-07-29T01:30:02Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=33016c491367c5144b3007927cd76492ac193d16'/>
<id>urn:sha1:33016c491367c5144b3007927cd76492ac193d16</id>
<content type='text'>
The location to pull from should be converted from the configured nickname
to URL in the message, but ls-remote should be fed the nickname so that
the command uses remote.$nickname.* variables, most notably "uploadpack".

Signed-off-by: Tom Grennan &lt;tgrennan@redback.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>request-pull: really really disable pager</title>
<updated>2009-07-01T20:20:00Z</updated>
<author>
<name>Michal Marek</name>
<email>mmarek@suse.cz</email>
</author>
<published>2009-07-01T09:40:30Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=653a31c16a0b83c11f00eb94ef49857ce8f2e37b'/>
<id>urn:sha1:653a31c16a0b83c11f00eb94ef49857ce8f2e37b</id>
<content type='text'>
Earlier 476cc72 (request-pull: really disable pager, 2009-06-30)
tried to use the correct environment variable to disable paging
from multiple calls to "git log" and friends, but there was one
extra call to "git log" that was not covered by the trick.

Move the setting and exporting of GIT_PAGER much earlier in the
script to cover everybody.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>request-pull: really disable pager</title>
<updated>2009-06-30T18:33:30Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2009-06-30T18:29:36Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=476cc724242e715c150dce0d26d2feabe2dbe5e1'/>
<id>urn:sha1:476cc724242e715c150dce0d26d2feabe2dbe5e1</id>
<content type='text'>
ff06c74 (Improve request-pull to handle non-rebased branches, 2007-05-01)
attempted to disable pager when running subcommands in this script, but
with a wrong variable.  If GIT_PAGER is set, it takes precedence over
PAGER.

Noticed by Michal Marek.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>request-pull: make usage string match manpage</title>
<updated>2008-11-17T10:27:18Z</updated>
<author>
<name>Stefan Naewe</name>
<email>stefan.naewe@atlas-elektronik.com</email>
</author>
<published>2008-11-17T08:57:19Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=3eb91bfc0d2e0c8c67bd4ec62523deb849919dd9'/>
<id>urn:sha1:3eb91bfc0d2e0c8c67bd4ec62523deb849919dd9</id>
<content type='text'>
The usage string of 'git request-pull' differs from he manpage
which gives the correct 'synopsis'.

Signed-off-by: Stefan Naewe &lt;stefan.naewe@atlas-elektronik.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
</feed>
