Git https://git.stealer.net/cgit.cgi/user/sven/git.git/atom?h=v1.8.0.2 2011-10-05T20:45:16Z 2011-10-05T20:45:16Z Michael Haggerty mhagger@alum.mit.edu 2011-09-23T13:38:36Z urn:sha1:d4e85a1afe0a3310a3c8336c2824775901cc27d7 Previously, get_sha1_hex() would read one character past the end of a null-terminated string whose strlen was an even number less than 40. Although the function correctly returned -1 in these cases, the extra memory access might have been to uninitialized (or even, conceivably, unallocated) memory. Add a check to avoid reading past the end of a string. This problem was discovered by Thomas Rast <trast@student.ethz.ch> using valgrind. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2010-01-22T04:03:45Z Linus Torvalds torvalds@linux-foundation.org 2010-01-21T23:25:19Z urn:sha1:a5031214c4fe5f5d3fcf649d10769744cbc66fed As the documentation says, this is primarily for debugging, and in the longer term we should rename it to test-show-index or something. In the meantime, just avoid xmalloc (which slurps in the rest of git), and separating out the trivial hex functions into "hex.o". This results in [torvalds@nehalem git]$ size git-show-index text data bss dec hex filename 222818 2276 112688 337782 52776 git-show-index (before) 5696 624 1264 7584 1da0 git-show-index (after) which is a whole lot better. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>