<feed xmlns='http://www.w3.org/2005/Atom'>
<title>user/sven/git.git/object.c, branch v1.5.6.4</title>
<subtitle>Git
</subtitle>
<id>https://git.stealer.net/cgit.cgi/user/sven/git.git/atom?h=v1.5.6.4</id>
<link rel='self' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/atom?h=v1.5.6.4'/>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/'/>
<updated>2008-02-04T00:04:57Z</updated>
<entry>
<title>parse_object_buffer: don't ignore errors from the object specific parsing functions</title>
<updated>2008-02-04T00:04:57Z</updated>
<author>
<name>Martin Koegler</name>
<email>mkoegler@auto.tuwien.ac.at</email>
</author>
<published>2008-02-03T21:22:39Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=d0b8c9e561ea427104611bf392598a398c18d7cb'/>
<id>urn:sha1:d0b8c9e561ea427104611bf392598a398c18d7cb</id>
<content type='text'>
In the case of an malformed object, the object specific parsing functions
would return an error, which is currently ignored. The object can be partial
initialized in this case.

This patch make parse_object_buffer propagate such errors.

Signed-off-by: Martin Koegler &lt;mkoegler@auto.tuwien.ac.at&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Don't dereference NULL upon lookup failure.</title>
<updated>2007-12-22T19:15:38Z</updated>
<author>
<name>Jim Meyering</name>
<email>meyering@redhat.com</email>
</author>
<published>2007-12-21T10:56:32Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=cc216827936e40bc2e8886623fd44f55e0674932'/>
<id>urn:sha1:cc216827936e40bc2e8886623fd44f55e0674932</id>
<content type='text'>
Instead, signal the error just like the case we do upon encountering
an object with an unknown type.

Signed-off-by: Jim Meyering &lt;meyering@redhat.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Don't assume tree entries that are not dirs are blobs</title>
<updated>2007-06-06T22:43:18Z</updated>
<author>
<name>Sam Vilain</name>
<email>sam.vilain@catalyst.net.nz</email>
</author>
<published>2007-06-06T10:25:17Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=e2ac7cb5fbcf1407003aa07cdcd14141527ea2e3'/>
<id>urn:sha1:e2ac7cb5fbcf1407003aa07cdcd14141527ea2e3</id>
<content type='text'>
When scanning the trees in track_tree_refs() there is a "lazy" test
that assumes that entries are either directories or files.  Don't do
that.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Merge branch 'maint-1.5.1' into maint</title>
<updated>2007-05-25T02:01:50Z</updated>
<author>
<name>Junio C Hamano</name>
<email>junkio@cox.net</email>
</author>
<published>2007-05-25T02:01:50Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=76026200eee9fea016c2d87f472bb13cb15f47b2'/>
<id>urn:sha1:76026200eee9fea016c2d87f472bb13cb15f47b2</id>
<content type='text'>
* maint-1.5.1:
  fix memory leak in parse_object when check_sha1_signature fails
  name-rev: tolerate clock skew in committer dates
</content>
</entry>
<entry>
<title>fix memory leak in parse_object when check_sha1_signature fails</title>
<updated>2007-05-25T01:56:06Z</updated>
<author>
<name>Carlos Rica</name>
<email>jasampler@gmail.com</email>
</author>
<published>2007-05-25T01:46:22Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=0b1f113075aafb0c91a406d984d0152e55c981da'/>
<id>urn:sha1:0b1f113075aafb0c91a406d984d0152e55c981da</id>
<content type='text'>
When check_sha1_signature fails, program is not terminated:
it prints an error message and returns NULL, so the
buffer returned by read_sha1_file should be freed before.

Signed-off-by: Carlos Rica &lt;jasampler@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
</content>
</entry>
<entry>
<title>add add_object_array_with_mode</title>
<updated>2007-04-24T07:08:49Z</updated>
<author>
<name>Martin Koegler</name>
<email>mkoegler@auto.tuwien.ac.at</email>
</author>
<published>2007-04-22T16:43:58Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=e5709a4a6809e45bf59b851debf24a813e1c6b58'/>
<id>urn:sha1:e5709a4a6809e45bf59b851debf24a813e1c6b58</id>
<content type='text'>
Each object in struct object_array is extended with the mode.
If not specified, S_IFINVALID is used. An object with an mode value
can be added with add_object_array_with_mode.

Signed-off-by: Martin Koegler &lt;mkoegler@auto.tuwien.ac.at&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
</content>
</entry>
<entry>
<title>Clean up object creation to use more common code</title>
<updated>2007-04-17T06:36:16Z</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@linux-foundation.org</email>
</author>
<published>2007-04-17T05:11:43Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=100c5f3b0b27ec6617de1a785c4ff481e92636c1'/>
<id>urn:sha1:100c5f3b0b27ec6617de1a785c4ff481e92636c1</id>
<content type='text'>
This replaces the fairly odd "created_object()" function that did _most_
of the object setup with a more complete "create_object()" function that
also has a more natural calling convention.

Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
</content>
</entry>
<entry>
<title>Use proper object allocators for unknown object nodes too</title>
<updated>2007-04-17T06:36:11Z</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@linux-foundation.org</email>
</author>
<published>2007-04-17T05:10:19Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=2c1cbec1e2f0bd7b15fe5e921d287babfd91c7d3'/>
<id>urn:sha1:2c1cbec1e2f0bd7b15fe5e921d287babfd91c7d3</id>
<content type='text'>
We used to use a different allocator scheme for when we didn't know the
object type.  That meant that objects that were created without any
up-front knowledge of the type would not go through the same allocation
paths as normal object allocations, and would miss out on the statistics.

But perhaps more importantly than the statistics (that are useful when
looking at memory usage but not much else), if we want to make the
object hash tables use a denser object pointer representation, we need
to make sure that they all go through the same blocking allocator.

Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
</content>
</entry>
<entry>
<title>Don't ever return corrupt objects from "parse_object()"</title>
<updated>2007-03-21T05:17:17Z</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@linux-foundation.org</email>
</author>
<published>2007-03-20T17:05:20Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=acdeec62cb644e48436bbe931e69b3d4842344cb'/>
<id>urn:sha1:acdeec62cb644e48436bbe931e69b3d4842344cb</id>
<content type='text'>
Looking at the SHA1 validation code due to the corruption that Alexander
Litvinov is seeing under Cygwin, I notice that one of the most central
places where we read objects, we actually do end up verifying the SHA1 of
the result, but then we happily parse it anyway.

And using "printf" to write the error message means that it not only can
get lost, but will actually mess up stdout, and cause other strange and
hard-to-debug failures downstream.

Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
</content>
</entry>
<entry>
<title>get rid of lookup_object_type()</title>
<updated>2007-02-27T09:34:21Z</updated>
<author>
<name>Nicolas Pitre</name>
<email>nico@cam.org</email>
</author>
<published>2007-02-26T19:56:00Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/git.git/commit/?id=0ab179504a17907c395a4009f7c23d2f71bba1d3'/>
<id>urn:sha1:0ab179504a17907c395a4009f7c23d2f71bba1d3</id>
<content type='text'>
This function is called only once in the whole source tree.  Let's move
its code inline instead, which is also in the spirit of removing as much
object type char arrays as possible (not that this patch does anything for
that but at least it is now a local matter).

Signed-off-by: Nicolas Pitre &lt;nico@cam.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
</content>
</entry>
</feed>
