user/sven/git.git/run-command.c, branch v1.5.6.4

run_command(): respect GIT_TRACE

2008-07-07T20:16:33Z

When GIT_TRACE is set, the user is most likely wanting to see an external command that is about to be executed. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano

run-command: Redirect stderr to a pipe before redirecting stdout to stderr

2008-03-05T20:18:03Z

With this patch, in the 'start_command' function after forking we now take care of stderr in the child process before stdout. This way if 'start_command' is called with a 'child_process' argument like this: .err = -1; .stdout_to_stderr = 1; then stderr will be redirected to a pipe before stdout is redirected to stderr. So we can now get the process' stdout from the pipe (as well as its stderr). Earlier such a call would have redirected stdout to stderr before stderr was itself redirected, and therefore stdout would not have followed stderr, which would not have been very useful anyway. Update documentation in 'api-run-command.txt' accordingly. Signed-off-by: Christian Couder Acked-by: Johannes Sixt Signed-off-by: Junio C Hamano

start_command(), if .in/.out > 0, closes file descriptors, not the callers

2008-02-23T19:59:44Z

Callers of start_command() can set the members .in and .out of struct child_process to a value > 0 to specify that this descriptor is used as the stdin or stdout of the child process. Previously, if start_command() was successful, this descriptor was closed upon return. Here we now make sure that the descriptor is also closed in case of failures. All callers are updated not to close the file descriptor themselves after start_command() was called. Note that earlier run_gpg_verify() of git-verify-tag set .out = 1, which worked because start_command() treated this as a special case, but now this is incorrect because it closes the descriptor. The intent here is to inherit stdout to the child, which is achieved by .out = 0. Signed-off-by: Johannes Sixt Signed-off-by: Junio C Hamano

start_command(), .in/.out/.err = -1: Callers must close the file descriptor

2008-02-23T19:59:44Z

By setting .in, .out, or .err members of struct child_process to -1, the callers of start_command() can request that a pipe is allocated that talks to the child process and one end is returned by replacing -1 with the file descriptor. Previously, a flag was set (for .in and .out, but not .err) to signal finish_command() to close the pipe end that start_command() had handed out, so it was optional for callers to close the pipe, and many already do so. Now we make it mandatory to close the pipe. Signed-off-by: Johannes Sixt Signed-off-by: Junio C Hamano

run-command: Support sending stderr to /dev/null

2007-11-12T01:09:55Z

Some callers may wish to redirect stderr to /dev/null in some contexts, such as if they are executing a command only to get the exit status and don't want users to see whatever output it may produce as a side-effect of computing that exit status. Signed-off-by: Shawn O. Pearce

Add infrastructure to run a function asynchronously.

2007-10-21T05:30:41Z

This adds start_async() and finish_async(), which runs a function asynchronously. Communication with the caller happens only via pipes. For this reason, this implementation forks off a child process that runs the function. [sp: Style nit fixed by removing unnecessary block on if condition inside of start_async()] Signed-off-by: Johannes Sixt Signed-off-by: Shawn O. Pearce

Have start_command() create a pipe to read the stderr of the child.

2007-10-21T05:30:40Z

This adds another stanza that allocates a pipe that is connected to the child's stderr and that the caller can read from. In order to request this pipe, the caller sets cmd->err to -1. The implementation is not exactly modeled after the stdout case: For stdout the caller can supply an existing file descriptor, but this facility is nowhere needed in the stderr case. Additionally, the caller is required to close cmd->err. Signed-off-by: Johannes Sixt Signed-off-by: Shawn O. Pearce

Allow environment variables to be unset in the processes started by run_command

2007-05-24T05:38:44Z

To unset a variable, just specify its name, without "=". For example: const char *env[] = {"GIT_DIR=.git", "PWD", NULL}; const char *argv[] = {"git-ls-files", "-s", NULL}; int err = run_command_v_opt_cd_env(argv, RUN_GIT_CMD, ".", env); The PWD will be unset before executing git-ls-files. Signed-off-by: Alex Riesen Signed-off-by: Junio C Hamano

Add ability to specify environment extension to run_command

2007-05-24T05:38:44Z

There is no way to specify and override for the environment: there'd be no user for it yet. Signed-off-by: Alex Riesen Signed-off-by: Junio C Hamano

Add run_command_v_opt_cd: chdir into a directory before exec

2007-05-24T05:38:44Z

It can make code simplier (no need to preserve cwd) and safer (no chance the cwd of the current process is accidentally forgotten). Signed-off-by: Alex Riesen Signed-off-by: Junio C Hamano