summaryrefslogtreecommitdiff
path: root/builtin/commit.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2021-05-01 10:04:34 -0400
committerJunio C Hamano <gitster@pobox.com>2021-05-03 14:30:46 +0900
commit6d52b6a5dfe0bee20dbfb2a3a7291bcf9a152672 (patch)
treea336a83b0d4ac3374ca662e1d3efbb000ddf5b37 /builtin/commit.c
parent49ac1d33bbd9d4be4ad8cb9730a07c086f688a5b (diff)
pack-objects: clamp negative depth to 0
A negative delta depth makes no sense, and the code is not prepared to handle it. If passed "--depth=-1" on the command line, then this line from break_delta_chains(): cur->depth = (total_depth--) % (depth + 1); triggers a divide-by-zero. This is undefined behavior according to the C standard, but on POSIX systems results in SIGFPE killing the process. This is certainly one way to inform the use that the command was invalid, but it's a bit friendlier to just treat it as "don't allow any deltas", which we already do for --depth=0. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions