summaryrefslogtreecommitdiff
path: root/builtin/commit.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2021-05-01 10:03:37 -0400
committerJunio C Hamano <gitster@pobox.com>2021-05-03 14:29:27 +0900
commit953aa54e1a6a7571d48eddea3ee68745bf94e69d (patch)
tree88a341bab20d94eb621c8313980576bd313133e2 /builtin/commit.c
parent95356789ee5e65abbdf3f354b8be4c79b196e8a1 (diff)
pack-objects: clamp negative window size to 0
A negative window size makes no sense, and the code in find_deltas() is not prepared to handle it. If you pass "-1", for example, we end up generate a 0-length array of "struct unpacked", but our loop assumes it has at least one entry in it (and we end up reading garbage memory). We could complain to the user about this, but it's more forgiving to just clamp it to 0, which means "do not find any deltas at all". The 0-case is already tested earlier in the script, so we'll make sure this does the same thing. Reported-by: Yiyuan guo <yguoaz@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions