summaryrefslogtreecommitdiff
path: root/git-gui/lib/encoding.tcl
diff options
context:
space:
mode:
authorMark Levedahl <mlevedahl@gmail.com>2025-09-30 19:35:59 -0400
committerMark Levedahl <mlevedahl@gmail.com>2025-10-04 10:31:40 -0400
commitb9f6b8237db9ebe999064e029c1b4784a7f4cfcd (patch)
treea9ae099cc9faffa33ac34cbf0a4ef33540a9f13c /git-gui/lib/encoding.tcl
parentc0932eda80bce73a72d73ded74a5e618c520afb2 (diff)
gitk: make configuration dialog resizing useful
gitk's configuration dialog can be resized, but this does not expand the space allocated to any widgets. Some items may have long lines of text that would be visible if the widgets expanded, but this does not happen. The top-level container uses a two column grid and allocates any space change equally to both columns. However, the configuration pages are contained in one cell so half the additional space is wasted if expanding. Also, the individual configuration pages do not mark any column or widgets to expand, so any additional space given is just used as padding. Collapse the top-level page to have one column, placing the "OK" and "Cancel" buttons in a non-resizing frame in column 1 (this keeps the buttons in constant geometry as the dialog is expanded). This makes all additional space go to the configuration page. Mark column 3 of the individual pages to get all additional space, and mark the text widgets in that column so they will expand to use the space. While we're at it, eliminate or simplify use of frames to contain column 2 content, and harmonize the indents of that content. prefspage_general adds a special "spacer" label in row 2, column 1, that causes all of the subsequent rows with no column 1 content to indent, and this carries over to the next notebook tab (prefspage_color) through some undocumented feature. The fonts page has a different indent, again for unknown reason. The documented approach would be to use -padx explicitly on all the rows to set the indents. Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
Diffstat (limited to 'git-gui/lib/encoding.tcl')
0 files changed, 0 insertions, 0 deletions