From bad79103998cd329584e844a315e85c3e1ac3839 Mon Sep 17 00:00:00 2001 From: René Scharfe Date: Tue, 4 Mar 2025 17:11:54 +0100 Subject: reftable: release name on reftable_reader_new() error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If block_source_read_block() or parse_footer() fail, we leak the "name" member of struct reftable_reader in reftable_reader_new(). Release it. Reported by: H Z Helped-by: Jeff King Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano --- reftable/reader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/reftable/reader.c b/reftable/reader.c index 3f2e4b2800..24bae50ac2 100644 --- a/reftable/reader.c +++ b/reftable/reader.c @@ -666,6 +666,8 @@ done: reftable_block_done(&footer); reftable_block_done(&header); if (err) { + if (r) + reftable_free(r->name); reftable_free(r); block_source_close(source); } -- cgit v1.2.3