From 7d6fb370bc98e5d4723103dda0829b00c79da213 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 24 Dec 2005 04:12:43 -0800 Subject: short circuit out of a few places where we would allocate zero bytes dietlibc versions of malloc, calloc and realloc all return NULL if they're told to allocate 0 bytes, causes the x* wrappers to die(). There are several more places where these calls could end up asking for 0 bytes, too... Maybe simply not die()-ing in the x* wrappers if 0/NULL is returned when the requested size is zero is a safer and easier way to go. Signed-off-by: Eric Wong Signed-off-by: Junio C Hamano --- commit.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'commit.c') diff --git a/commit.c b/commit.c index e867b86e6a..edd4dedcdd 100644 --- a/commit.c +++ b/commit.c @@ -560,6 +560,9 @@ void sort_in_topological_order(struct commit_list ** list) next = next->next; count++; } + + if (!count) + return; /* allocate an array to help sort the list */ nodes = xcalloc(count, sizeof(*nodes)); /* link the list to the array */ -- cgit v1.2.3