From 28dc26dc337932d9e4df8f83f1e454ea6bbc0897 Mon Sep 17 00:00:00 2001 From: René Scharfe Date: Wed, 19 Jun 2024 19:13:19 +0200 Subject: commit: remove find_header_mem() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cfc5cf428b (receive-pack.c: consolidate find header logic, 2022-01-06) introduced find_header_mem() and turned find_commit_header() into a thin wrapper. Since then, the latter has become the last remaining caller of the former. Remove it to restore find_commit_header() to the state before cfc5cf428b, get rid of a strlen(3) call and resolve a NEEDSWORK note in the process. Signed-off-by: René Scharfe Acked-by: Jeff King Signed-off-by: Junio C Hamano --- commit.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'commit.h') diff --git a/commit.h b/commit.h index 1cc872f225..cab8c6bace 100644 --- a/commit.h +++ b/commit.h @@ -280,17 +280,12 @@ void free_commit_extra_headers(struct commit_extra_header *extra); /* * Search the commit object contents given by "msg" for the header "key". - * Reads up to "len" bytes of "msg". * Returns a pointer to the start of the header contents, or NULL. The length * of the header, up to the first newline, is returned via out_len. * * Note that some headers (like mergetag) may be multi-line. It is the caller's * responsibility to parse further in this case! */ -const char *find_header_mem(const char *msg, size_t len, - const char *key, - size_t *out_len); - const char *find_commit_header(const char *msg, const char *key, size_t *out_len); -- cgit v1.2.3