user/sven/linux.git/block/blk-timeout.c, branch v3.0-rc5

block: ensure jiffies wrap is handled correctly in blk_rq_timed_out_timer

2010-04-21T15:42:08Z

blk_rq_timed_out_timer() relied on blk_add_timer() never returning a timer value of zero, but commit 7838c15b8dd18e78a523513749e5b54bda07b0cb removed the code that bumped this value when it was zero. Therefore when jiffies is near wrap we could get unlucky & not set the timeout value correctly. This patch uses a flag to indicate that the timeout value was set and so handles jiffies wrap correctly, and it keeps all the logic in one function so should be easier to maintain in the future. Signed-off-by: Richard Kennedy Cc: stable@kernel.org Signed-off-by: Jens Axboe

block: clean up misc stuff after block layer timeout conversion

2009-04-28T05:37:34Z

* In blk_rq_timed_out_timer(), else { if } to else if * In blk_add_timer(), simplify if/else block [ Impact: cleanup ] Signed-off-by: Tejun Heo

block: fix intermittent dm timeout based oops

2009-04-24T06:54:21Z

Very rarely under stress testing of dm, oopses are occuring as something tampers with an old stack frame. This has been traced back to blk_abort_queue() leaving a timeout_list pointing to the stack. The reason is that sometimes blk_abort_request() won't delete the timer (if the request is marked as complete but before the timer has been removed, a small race window). Fix this by splicing back from the ususally empty list to the q->timeout_list. Signed-off-by: Hannes Reinecke Signed-off-by: Jens Axboe

block: make blk_abort_queue() ignore non-request based devices

2009-04-22T06:35:10Z

There's nothing to do for those devices, since the timeout handling is based on requests. Signed-off-by: Jens Axboe

block: fix deadlock in blk_abort_queue() for drivers that readd to timeout list

2009-02-18T09:34:16Z

blk_abort_queue() iterates the timeout list and aborts each request on the list, but if the driver error handling readds a request to the timeout list during this processing, we could be looping forever. Fix this by splicing current entries to a local list and run over that list instead. Signed-off-by: Jens Axboe

block: leave the request timeout timer running even on an empty list

2008-12-29T07:28:42Z

For sync IO, we'll often do them serialized. This means we'll be touching the queue timer for every IO, as opposed to only occasionally like we do for queued IO. Instead of deleting the timer when the last request is removed, just let continue running. If a new request comes up soon we then don't have to readd the timer again. If no new requests arrive, the timer will expire without side effect later. This improves high iops sync IO by ~1%. Signed-off-by: Jens Axboe

block: add comment in blk_rq_timed_out() about why next can not be 0

2008-12-29T07:28:42Z

Signed-off-by: Jens Axboe

block: optimizations in blk_rq_timed_out_timer()

2008-12-29T07:28:42Z

Now the rq->deadline can't be zero if the request is in the timeout_list, so there is no need to have next_set. There is no need to access a request's deadline field if blk_rq_timed_out is called on it. Signed-off-by: Malahal Naineni Signed-off-by: Jens Axboe

Block: use round_jiffies_up()

2008-11-06T07:42:49Z

This patch (as1159b) changes the timeout routines in the block core to use round_jiffies_up(). There's no point in rounding the timer deadline down, since if it expires too early we will have to restart it. The patch also removes some unnecessary tests when a request is removed from the queue's timer list. Signed-off-by: Alan Stern Signed-off-by: Jens Axboe

block: use rq complete marking in blk_abort_request()

2008-10-09T06:56:17Z

We cannot abort a request if we raced with the timeout handler already, or with the IO completion. So make blk_abort_request() mark the request as complete, and only continue if we succeeded. Found and suggested by Mike Anderson Signed-off-by: Jens Axboe