<feed xmlns='http://www.w3.org/2005/Atom'>
<title>user/sven/linux.git/drivers/ide/icside.c, branch v3.16.67</title>
<subtitle>Linux Kernel
</subtitle>
<id>https://git.stealer.net/cgit.cgi/user/sven/linux.git/atom?h=v3.16.67</id>
<link rel='self' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/atom?h=v3.16.67'/>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/'/>
<updated>2013-01-03T23:57:03Z</updated>
<entry>
<title>Drivers: ide: remove __dev* attributes.</title>
<updated>2013-01-03T23:57:03Z</updated>
<author>
<name>Greg Kroah-Hartman</name>
<email>gregkh@linuxfoundation.org</email>
</author>
<published>2012-12-21T21:21:03Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=fe31edc8a3b6081f3580c9ae4c5c61103f3412a5'/>
<id>urn:sha1:fe31edc8a3b6081f3580c9ae4c5c61103f3412a5</id>
<content type='text'>
CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton &lt;wfp5p@virginia.edu&gt;
Cc: "David S. Miller" &lt;davem@davemloft.net&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
</content>
</entry>
<entry>
<title>sections: fix section conflicts in drivers/ide</title>
<updated>2012-10-05T18:04:41Z</updated>
<author>
<name>Andi Kleen</name>
<email>ak@linux.intel.com</email>
</author>
<published>2012-10-05T00:11:48Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=e6b53703b9966a3636be2bd4b7b8e0bfeb1b3f8d'/>
<id>urn:sha1:e6b53703b9966a3636be2bd4b7b8e0bfeb1b3f8d</id>
<content type='text'>
Signed-off-by: Andi Kleen &lt;ak@linux.intel.com&gt;
Cc: David Miller &lt;davem@davemloft.net&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
</entry>
<entry>
<title>ide: icside.c: fix printk format string compile warning</title>
<updated>2012-06-06T17:36:47Z</updated>
<author>
<name>Christian Dietrich</name>
<email>christian.dietrich@informatik.uni-erlangen.de</email>
</author>
<published>2012-06-05T02:28:59Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=027253c138a12b075e724f94b6cc43fd7071c14f'/>
<id>urn:sha1:027253c138a12b075e724f94b6cc43fd7071c14f</id>
<content type='text'>
Use correct format string parameter for the peak datarate, and prevent
uninitialized use of cycle_time.

Signed-off-by: Christian Dietrich &lt;christian.dietrich@informatik.uni-erlangen.de&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>ide: icside.c: Fix compile with CONFIG_BLK_DEV_IDEDMA_ICS=n</title>
<updated>2012-06-06T17:36:47Z</updated>
<author>
<name>Christian Dietrich</name>
<email>christian.dietrich@informatik.uni-erlangen.de</email>
</author>
<published>2012-06-05T02:23:20Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=32a527add871a51b3c06177849d18bf71e33b320'/>
<id>urn:sha1:32a527add871a51b3c06177849d18bf71e33b320</id>
<content type='text'>
The icside driver can be configured without DMA support, but it
doesn't compile then, because DMA operations are referenced.

drivers/ide/icside.c:523: error: 'icside_v6_port_ops' undeclared
drivers/ide/icside.c:522: error: 'icside_dma_init' undeclared

Signed-off-by: Christian Dietrich&lt;christian.dietrich@informatik.uni-erlangen.de&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>icside: DMA support fix</title>
<updated>2011-10-13T21:04:50Z</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2011-10-12T04:45:34Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=acc8dbe7f44f1bab6fcf21f2d5efb32ea92e19fd'/>
<id>urn:sha1:acc8dbe7f44f1bab6fcf21f2d5efb32ea92e19fd</id>
<content type='text'>
Fix problem introduced by commit 5e37bdc ("ide: add struct
ide_dma_ops (take 3)"): d.dma_ops shouldn't be cleared if
we are going to use DMA.

Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/ide-2.6</title>
<updated>2010-03-03T07:57:59Z</updated>
<author>
<name>David S. Miller</name>
<email>davem@davemloft.net</email>
</author>
<published>2010-03-03T07:57:59Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=950f564b707ca1b1c5bb94cd1e7d2a0702bfcadc'/>
<id>urn:sha1:950f564b707ca1b1c5bb94cd1e7d2a0702bfcadc</id>
<content type='text'>
</content>
</entry>
<entry>
<title>ide: change -&gt;set_dma_mode method parameters</title>
<updated>2010-01-19T09:45:29Z</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2010-01-19T09:45:29Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=8776168ca2151850164af1de5565d01f7b8b2c53'/>
<id>urn:sha1:8776168ca2151850164af1de5565d01f7b8b2c53</id>
<content type='text'>
Change -&gt;set_dma_mode method parameters to match -&gt;set_dmamode method
used in struct ata_port_operations.

Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
</entry>
<entry>
<title>icside: bring back -&gt;maskproc method</title>
<updated>2010-01-12T09:49:23Z</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2010-01-05T07:07:27Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=f75d4a238770d83d3a0475ce7f34e3fa37de161e'/>
<id>urn:sha1:f75d4a238770d83d3a0475ce7f34e3fa37de161e</id>
<content type='text'>
Bring back -&gt;maskproc method since it is still needed for proper operation,
as noticed by Russell King:

&gt; This change is bogus.
&gt;
&gt;         writeb(0, base + ICS_ARCIN_V6_INTROFFSET_1);
&gt;         readb(base + ICS_ARCIN_V6_INTROFFSET_2);
&gt;
&gt;         writeb(0, base + ICS_ARCIN_V6_INTROFFSET_2);
&gt;         readb(base + ICS_ARCIN_V6_INTROFFSET_1);
&gt;
&gt; This sequence of code does:
&gt;
&gt; 1. enable interrupt 1
&gt; 2. disable interrupt 2
&gt; 3. enable interrupt 2
&gt; 4. disable interrupt 1
&gt;
&gt; which results in the interrupt for the second channel being enabled -
&gt; leaving channel 1 blocked.
&gt;
&gt; Firstly, icside shares its two IDE channels with one DMA engine - so it's
&gt; a simplex interface.  IDE supports those (or did when the code was written)
&gt; serializing requests between the two interfaces.  libata does not.
&gt;
&gt; Secondly, the interrupt lines on icside float when there's no drive connected
&gt; or when the drive has its NIEN bit set, which means that you get spurious
&gt; screaming interrupts which can kill off all expansion card interrupts on
&gt; the machine unless you disable the channel interrupt on the card.
&gt;
&gt; Since libata can not serialize the operation of the two channels like IDE
&gt; can, the libata version of the icside driver does not contain the interrupt
&gt; stearing logic.  Instead, it looks at the status after reset, and if
&gt; nothing was found on that channel, it masks the interrupt from that
&gt; channel.

This patch reverts changes done in commit dff8817 (I became confused due to
non-standard &amp; undocumented -&gt;maskproc method, anyway sorry about that).

Noticed-by: Russell King &lt;rmk@arm.linux.org.uk&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
</entry>
<entry>
<title>ide: do not access ide_drive_t 'drive_data' field directly</title>
<updated>2009-06-15T20:13:44Z</updated>
<author>
<name>Joao Ramos</name>
<email>joao.ramos@inov.pt</email>
</author>
<published>2009-06-15T20:13:44Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=5bfb151f1f565e6082304a30e8c81dfb6ed0b0c8'/>
<id>urn:sha1:5bfb151f1f565e6082304a30e8c81dfb6ed0b0c8</id>
<content type='text'>
Change ide_drive_t 'drive_data' field from 'unsigned int' type to 'void *'
type, allowing a wider range of values/types to be stored in this field.

Added 'ide_get_drivedata' and 'ide_set_drivedata' helpers to get and set
the 'drive_data' field.

Fixed all host drivers to maintain coherency with the change in the
'drive_data' field type.

Signed-off-by: Joao Ramos &lt;joao.ramos@inov.pt&gt;
[bart: fix qd65xx build, cast to 'unsigned long', minor Coding Style fixups]
Acked-by: Sergei Shtylyov &lt;sshtylyov@ru.montavista.com&gt;
Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
</entry>
<entry>
<title>icside: remove superfluous -&gt;maskproc method</title>
<updated>2009-06-07T13:37:06Z</updated>
<author>
<name>Bartlomiej Zolnierkiewicz</name>
<email>bzolnier@gmail.com</email>
</author>
<published>2009-06-07T13:37:06Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=dff8817b78e6e6a4913f2caf7637d62dcc49a03c'/>
<id>urn:sha1:dff8817b78e6e6a4913f2caf7637d62dcc49a03c</id>
<content type='text'>
[inspired by pata_icside]

Enabling/disabling of card IRQs is handled fine by IRQ and IDE
subsystems so there is no need for custom -&gt;maskproc method.

Moreover icside_maskproc() would enable IRQ only if it was already
enabled [because of 'if (state-&gt;enabled &amp;&amp; !mask)' check].

Signed-off-by: Bartlomiej Zolnierkiewicz &lt;bzolnier@gmail.com&gt;
</content>
</entry>
</feed>
