user/sven/linux.git/drivers/ntb, branch stable/6.9.y

NTB: fix possible name leak in ntb_register_device()

2024-02-16T10:43:38Z

If device_register() fails in ntb_register_device(), the device name allocated by dev_set_name() should be freed. As per the comment in device_register(), callers should use put_device() to give up the reference in the error path. So fix this by calling put_device() in the error path so that the name can be freed in kobject_cleanup(). As a result of this, put_device() in the error path of ntb_register_device() is removed and the actual error is returned. Fixes: a1bd3baeb2f1 ("NTB: Add NTB hardware abstraction layer") Signed-off-by: Yang Yingliang Reviewed-by: Ilpo Järvinen Reviewed-by: Manivannan Sadhasivam Reviewed-by: Dave Jiang Link: https://lore.kernel.org/r/20231201033057.1399131-1-yangyingliang@huaweicloud.com [mani: reworded commit message] Signed-off-by: Manivannan Sadhasivam

ntb: Check tx descriptors outstanding instead of head/tail for tx queue

2023-08-22T16:38:19Z

Use existing function ntb_transport_tx_free_entry() instead of open coding the check to see if there are outstanding tx descriptors. Reviewed-by: Logan Gunthorpe Signed-off-by: Dave Jiang Signed-off-by: Jon Mason

ntb: Fix calculation ntb_transport_tx_free_entry()

2023-08-22T16:38:19Z

ntb_transport_tx_free_entry() never returns 0 with the current calculation. If head == tail, then it would return qp->tx_max_entry. Change compare to tail >= head and when they are equal, a 0 would be returned. Fixes: e74bfeedad08 ("NTB: Add flow control to the ntb_netdev") Reviewed-by: Logan Gunthorpe Signed-off-by: renlonglong Signed-off-by: Dave Jiang Signed-off-by: Jon Mason

ntb: Drop packets when qp link is down

2023-08-22T16:38:19Z

Currently when the transport receive packets after netdev has closed the transport returns error and triggers tx errors to be incremented and carrier to be stopped. There is no reason to return error if the device is already closed. Drop the packet and return 0. Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") Reported-by: Yuan Y Lu Tested-by: Yuan Y Lu Reviewed-by: Logan Gunthorpe Signed-off-by: Dave Jiang Signed-off-by: Jon Mason

ntb: Clean up tx tail index on link down

2023-08-22T16:38:19Z

The tx tail index is not reset when the link goes down. This causes the tail index to go out of sync when the link goes down and comes back up. Refactor the ntb_qp_link_down_reset() and reset the tail index as well. Fixes: 2849b5d70641 ("NTB: Reset transport QP link stats on down") Reported-by: Yuan Y Lu Tested-by: Yuan Y Lu Reviewed-by: Logan Gunthorpe Signed-off-by: Dave Jiang Signed-off-by: Jon Mason

ntb: amd: Drop unnecessary error check for debugfs_create_dir

2023-08-18T13:50:06Z

This patch removes the error checking for debugfs_create_dir in ntb_hw_amd.c. This is because the DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in start_creating() which can handle it gracefully. so these checks are unnecessary. Signed-off-by: Ruan Jinjie Acked-by: Sanjay R Mehta Signed-off-by: Jon Mason

NTB: ntb_tool: Switch to memdup_user_nul() helper

2023-08-18T13:50:06Z

Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Ruan Jinjie Reviewed-by: Dave Jiang Reviewed-by: Dan Carpenter Reviewed-by: Serge Semin Signed-off-by: Jon Mason

dtivers: ntb: fix parameter check in perf_setup_dbgfs()

2023-08-18T13:50:06Z

Make IS_ERR() judge the debugfs_create_dir() function return in perf_setup_dbgfs(). Signed-off-by: Minjie Du Reviewed-by: Serge Semin Signed-off-by: Jon Mason

ntb: Remove error checking for debugfs_create_dir()

2023-08-18T13:50:06Z

It is expected that most callers should _ignore_ the errors return by debugfs_create_dir() in tool_setup_dbgfs() Signed-off-by: Wang Ming Reviewed-by: Dave Jiang Reviewed-by: Dan Carpenter Reviewed-by: Serge Semin Signed-off-by: Jon Mason

ntb: hw: amd: Fix debugfs_create_dir error checking

2023-07-08T17:55:44Z

The debugfs_create_dir function returns ERR_PTR in case of error, and the only correct way to check if an error occurred is 'IS_ERR' inline function. This patch will replace the null-comparison with IS_ERR. Signed-off-by: Anup Sharma Suggested-by: Ivan Orlov Signed-off-by: Jon Mason