user/sven/linux.git/fs/pipe.c, branch stable/4.3.y

fs/pipe.c: return error code rather than 0 in pipe_write()

2016-02-19T22:28:38Z

commit 6ae08069939f17422835448acae76bda8d96b16a upstream. pipe_write() would return 0 if it failed to merge the beginning of the data to write with the last, partially filled pipe buffer. It should return an error code instead. Userspace programs could be confused by write() returning 0 when called with a nonzero 'count'. The EFAULT error case was a regression from f0d1bec9d5 ("new helper: copy_page_from_iter()"), while the ops->confirm() error case was a much older bug. Test program: #include #include #include int main(void) { int fd[2]; char data[1] = {0}; assert(0 == pipe(fd)); assert(1 == write(fd[1], data, 1)); /* prior to this patch, write() returned 0 here */ assert(-1 == write(fd[1], NULL, 1)); assert(errno == EFAULT); } Signed-off-by: Eric Biggers Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman

VFS: assorted weird filesystems: d_inode() annotations

2015-04-15T19:06:58Z

Signed-off-by: David Howells Signed-off-by: Al Viro

make new_sync_{read,write}() static

2015-04-12T02:29:40Z

All places outside of core VFS that checked ->read and ->write for being NULL or called the methods directly are gone now, so NULL {read,write} with non-NULL {read,write}_iter will do the right thing in all cases. Signed-off-by: Al Viro

fs: move struct kiocb to fs.h

2015-03-26T00:28:11Z

struct kiocb now is a generic I/O container, so move it to fs.h. Also do a #include diet for aio.h while we're at it. Signed-off-by: Christoph Hellwig Signed-off-by: Al Viro

new helper: copy_page_from_iter()

2014-05-06T21:39:42Z

parallel to copy_page_to_iter(). pipe_write() switched to it (and became ->write_iter()). Signed-off-by: Al Viro

pipe: switch to ->read_iter()

2014-05-06T21:37:58Z

Signed-off-by: Al Viro

start adding the tag to iov_iter

2014-05-06T21:32:49Z

For now, just use the same thing we pass to ->direct_IO() - it's all iovec-based at the moment. Pass it explicitly to iov_iter_init() and account for kvec vs. iovec in there, by the same kludge NFS ->direct_IO() uses. Signed-off-by: Al Viro

switch pipe_read() to copy_page_to_iter()

2014-04-02T03:19:22Z

Signed-off-by: Al Viro

pipe: kill ->map() and ->unmap()

2014-04-02T03:19:19Z

all pipe_buffer_operations have the same instances of those... Signed-off-by: Al Viro

fs/pipe.c: skip file_update_time on frozen fs

2014-01-24T00:37:00Z

Pipe has no data associated with fs so it is not good idea to block pipe_write() if FS is frozen, but we can not update file's time on such filesystem. Let's use same idea as we use in touch_time(). Addresses https://bugzilla.kernel.org/show_bug.cgi?id=65701 Signed-off-by: Dmitry Monakhov Reviewed-by: Jan Kara Cc: Al Viro Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds