user/sven/linux.git/include/net/route.h, branch stable/3.2.y

ipv4: reset flowi parameters on route connect

2012-03-01T00:31:00Z

[ Upstream commit e6b45241c57a83197e5de9166b3b0d32ac562609 ] Eric Dumazet found that commit 813b3b5db83 (ipv4: Use caller's on-stack flowi as-is in output route lookups.) that comes in 3.0 added a regression. The problem appears to be that resulting flowi4_oif is used incorrectly as input parameter to some routing lookups. The result is that when connecting to local port without listener if the IP address that is used is not on a loopback interface we incorrectly assign RTN_UNICAST to the output route because no route is matched by oif=lo. The RST packet can not be sent immediately by tcp_v4_send_reset because it expects RTN_LOCAL. So, change ip_route_connect and ip_route_newports to update the flowi4 fields that are input parameters because we do not want unnecessary binding to oif. To make it clear what are the input parameters that can be modified during lookup and to show which fields of floiw4 are reused add a new function to update the flowi4 structure: flowi4_update_output. Thanks to Yurij M. Plotnikov for providing a bug report including a program to reproduce the problem. Thanks to Eric Dumazet for tracking the problem down to tcp_v4_send_reset and providing initial fix. Reported-by: Yurij M. Plotnikov Signed-off-by: Julian Anastasov Acked-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman

route: struct rtable can be const in rt_is_input_route and rt_is_output_route

2011-11-26T19:29:51Z

Signed-off-by: Steffen Klassert Signed-off-by: David S. Miller

ipv4: Pass explicit destination address to rt_bind_peer().

2011-05-18T22:42:43Z

Signed-off-by: David S. Miller

ipv4: Pass explicit destination address to rt_get_peer().

2011-05-18T22:38:54Z

This will next trickle down to rt_bind_peer(). Signed-off-by: David S. Miller

ipv4: Remove route key identity dependencies in ip_rt_get_source().

2011-05-13T21:29:41Z

Pass in the sk_buff so that we can fetch the necessary keys from the packet header when working with input routes. Signed-off-by: David S. Miller

ipv4: Kill rt->rt_{src, dst} usage in IP GRE tunnels.

2011-05-04T19:55:07Z

First, make callers pass on-stack flowi4 to ip_route_output_gre() so they can get at the fully resolved flow key. Next, use that in ipgre_tunnel_xmit() to avoid the need to use rt->rt_{dst,src}. Signed-off-by: David S. Miller

ipv4: Make caller provide on-stack flow key to ip_route_output_ports().

2011-05-04T03:25:42Z

Signed-off-by: David S. Miller

ipv4: Renamt struct rtable's rt_tos to rt_key_tos.

2011-05-04T02:45:15Z

To more accurately reflect that it is purely a routing cache lookup key and is used in no other context. Signed-off-by: David S. Miller

ipv4: Remove now superfluous code in ip_route_connect().

2011-04-29T06:13:17Z

Now that output route lookups update the flow with source address et al. selections, the fl4->{saddr,daddr} assignments here are no longer necessary. Signed-off-by: David S. Miller

ipv4: Use caller's on-stack flowi as-is in output route lookups.

2011-04-29T05:26:00Z

Signed-off-by: David S. Miller