user/sven/linux.git/include/net/secure_seq.h, branch v3.4.15Linux Kernel
https://git.stealer.net/cgit.cgi/user/sven/linux.git/atom?h=v3.4.152011-10-21T09:22:42Ztcp: add const qualifiers where possible2011-10-21T09:22:42ZEric Dumazeteric.dumazet@gmail.com2011-10-21T09:22:42Zurn:sha1:cf533ea53ebfae41be15b103d78e7ebec30b9969
Adding const qualifiers to pointers can ease code review, and spot some
bugs. It might allow compiler to optimize code further.
For example, is it legal to temporary write a null cksum into tcphdr
in tcp_md5_hash_header() ? I am afraid a sniffer could catch the
temporary null value...
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: Compute protocol sequence numbers and fragment IDs using MD5.2011-08-07T01:33:19ZDavid S. Millerdavem@davemloft.net2011-08-04T03:50:44Zurn:sha1:6e5714eaf77d79ae1c8b47e3e040ff5411b717ec
Computers have become a lot faster since we compromised on the
partial MD4 hash which we use currently for performance reasons.
MD5 is a much safer choice, and is inline with both RFC1948 and
other ISS generators (OpenBSD, Solaris, etc.)
Furthermore, only having 24-bits of the sequence number be truly
unpredictable is a very serious limitation. So the periodic
regeneration and 8-bit counter have been removed. We compute and
use a full 32-bit sequence number.
For ipv6, DCCP was found to use a 32-bit truncated initial sequence
number (it needs 43-bits) and that is fixed here as well.
Reported-by: Dan Kaminsky <dan@doxpara.com>
Tested-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>