<feed xmlns='http://www.w3.org/2005/Atom'>
<title>user/sven/linux.git/kernel/params.c, branch v2.6.12.2</title>
<subtitle>Linux Kernel
</subtitle>
<id>https://git.stealer.net/cgit.cgi/user/sven/linux.git/atom?h=v2.6.12.2</id>
<link rel='self' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/atom?h=v2.6.12.2'/>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/'/>
<updated>2005-04-16T22:25:42Z</updated>
<entry>
<title>[PATCH] kernel/param.c: don't use .max when .num is NULL in param_array_set()</title>
<updated>2005-04-16T22:25:42Z</updated>
<author>
<name>Bert Wesarg</name>
<email>wesarg@informatik.uni-halle.de</email>
</author>
<published>2005-04-16T22:25:42Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=31143a12044caa3521edafd736e3bc18c098d2fd'/>
<id>urn:sha1:31143a12044caa3521edafd736e3bc18c098d2fd</id>
<content type='text'>
there seems to be a bug, at least for me, in kernel/param.c for arrays with
.num == NULL.  If .num == NULL, the function param_array_set() uses &amp;.max
for the call to param_array(), wich alters the .max value to the number of
arguments.  The result is, you can't set more array arguments as the last
time you set the parameter.

example:

# a module 'example' with
# static int array[10] = { 0, };
# module_param_array(array, int, NULL, 0644);

$ insmod example.ko array=1,2,3
$ cat /sys/module/example/parameters/array
1,2,3
$ echo "4,3,2,1" &gt; /sys/module/example/parameters/array
$ dmesg | tail -n 1
kernel: array: can take only 3 arguments

Signed-off-by: Bert Wesarg &lt;wesarg@informatik.uni-halle.de&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
</entry>
<entry>
<title>[PATCH] Modules: Allow sysfs module parameters to be written to.</title>
<updated>2005-01-25T04:49:07Z</updated>
<author>
<name>Greg Kroah-Hartman</name>
<email>greg@kroah.com</email>
</author>
<published>2005-01-25T04:49:07Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=5781864c26406a8a336e2f888f7d6b5abaebcbd6'/>
<id>urn:sha1:5781864c26406a8a336e2f888f7d6b5abaebcbd6</id>
<content type='text'>
This fixes a bug in the current tree preventing the sysfs module
parameters from being able to be changed at all from userspace.  It's as
if someone just forgot to write this function...

Signed-off-by: Greg Kroah-Hartman &lt;greg@kroah.com&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
</entry>
<entry>
<title>merge</title>
<updated>2005-01-07T06:36:18Z</updated>
<author>
<name>Greg Kroah-Hartman</name>
<email>greg@kroah.com</email>
</author>
<published>2005-01-07T06:36:18Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=2354096ea3829086d2ba83f6dbfe961ce5500bfe'/>
<id>urn:sha1:2354096ea3829086d2ba83f6dbfe961ce5500bfe</id>
<content type='text'>
</content>
</entry>
<entry>
<title>[PATCH] handle quoted module parameters</title>
<updated>2005-01-04T13:26:05Z</updated>
<author>
<name>Randy Dunlap</name>
<email>rddunlap@osdl.org</email>
</author>
<published>2005-01-04T13:26:05Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=08ccfcc14c06015f62144b309ceab92abf510bd6'/>
<id>urn:sha1:08ccfcc14c06015f62144b309ceab92abf510bd6</id>
<content type='text'>
Fix module parameter quote handling.
Module parameter strings (with spaces) are quoted like so:
"modprm=this test"
and not like this:
modprm="this test"

Signed-off-by: Randy Dunlap &lt;rddunlap@osdl.org&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
</entry>
<entry>
<title>[PATCH] module sysfs: module parameters reimplemented using attr group</title>
<updated>2004-12-21T02:36:52Z</updated>
<author>
<name>Tejun Heo</name>
<email>tj@home-tj.org</email>
</author>
<published>2004-12-21T02:36:52Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=fcf7104e3c6e9a4b2db96204e8f06efbe14cf258'/>
<id>urn:sha1:fcf7104e3c6e9a4b2db96204e8f06efbe14cf258</id>
<content type='text'>
        Reimplement parameter attributes using attribute group.
	This makes more sense, for, while they reside in a separate
        subdirectory, they belong to the ownig module and their
        lifetime exactly equals the lifetime of the owning module,
        and it's simpler.


Signed-off-by: Tejun Heo &lt;tj@home-tj.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;greg@kroah.com&gt;
</content>
</entry>
<entry>
<title>[PATCH] module sysfs: expand module_attribute methods</title>
<updated>2004-12-21T02:36:20Z</updated>
<author>
<name>Tejun Heo</name>
<email>tj@home-tj.org</email>
</author>
<published>2004-12-21T02:36:20Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=6239c1cfe8b95d18533ca82d9b6d7cf7c55028a1'/>
<id>urn:sha1:6239c1cfe8b95d18533ca82d9b6d7cf7c55028a1</id>
<content type='text'>
        Modify module_attribute show/store methods to accept self
        argument to enable further extensions.


Signed-off-by: Tejun Heo &lt;tj@home-tj.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;greg@kroah.com&gt;
</content>
</entry>
<entry>
<title>[PATCH] module sysfs: make module.mkobj inline</title>
<updated>2004-12-21T02:36:03Z</updated>
<author>
<name>Tejun Heo</name>
<email>tj@home-tj.org</email>
</author>
<published>2004-12-21T02:36:03Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=b86ab02803095190d6b72bcc18dcf620bf378df9'/>
<id>urn:sha1:b86ab02803095190d6b72bcc18dcf620bf378df9</id>
<content type='text'>
    Make module.mkobj inline.  As this is simpler and what's
    usually done with kobjs when it's representing an entity.


Signed-off-by: Tejun Heo &lt;tj@home-tj.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;greg@kroah.com&gt;
</content>
</entry>
<entry>
<title>[PATCH] Builtin Module Parameters in sysfs too</title>
<updated>2004-10-25T11:19:51Z</updated>
<author>
<name>Rusty Russell</name>
<email>rusty@rustcorp.com.au</email>
</author>
<published>2004-10-25T11:19:51Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=1857599ace885dfb946dbdcc9a754be40a3b9c3c'/>
<id>urn:sha1:1857599ace885dfb946dbdcc9a754be40a3b9c3c</id>
<content type='text'>
Currently, only module parameters in loaded modules are exported in
/sys/modules/, while those of "modules" built into the kernel can be set by
the kernel command line, but not read or set via sysfs.

- move module parameters from /sys/modules/$(module_name)/$(parameter_name) to
  /sys/modules/$(module_name)/parameters/$(parameter_name)

- remove dummy kernel_param for exporting refcnt, add "struct module *"-based
  attribute instead

- also export module paramters for "modules" which are built into the kernel,
  so parameters are always accessible at
  /sys/modules/$(KBUILD_MODNAME)/$(parameter_name)

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt; (modified)
Signed-off-by: Dominik Brodowski &lt;linux@brodo.de&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
</entry>
<entry>
<title>[PATCH] module_param_array() should take a pointer</title>
<updated>2004-10-20T01:10:43Z</updated>
<author>
<name>Rusty Russell</name>
<email>rusty@rustcorp.com.au</email>
</author>
<published>2004-10-20T01:10:43Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=9229204bae3b2928b68351bc3a2c26769ea74047'/>
<id>urn:sha1:9229204bae3b2928b68351bc3a2c26769ea74047</id>
<content type='text'>
module_param_array() takes a variable to put the number of elements in. 
Looking through the uses, many people don't care, so they declare a dummy
or share one variable between several parameters.  The latter is
problematic because sysfs uses that number to decide how many to display.

The solution is to change the variable arg to a pointer, and if the pointer
is NULL, use the "max" value.  This change is fairly small, but fixing up
the callers is a lot of (trivial) churn.

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
Signed-off-by: Andrew Morton &lt;akpm@osdl.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
</content>
</entry>
<entry>
<title>Merge bk://kernel.bkbits.net/gregkh/linux/pci-2.6</title>
<updated>2004-08-23T07:22:41Z</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@ppc970.osdl.org</email>
</author>
<published>2004-08-23T07:22:41Z</published>
<link rel='alternate' type='text/html' href='https://git.stealer.net/cgit.cgi/user/sven/linux.git/commit/?id=359f482533ebf0c974eabbcc83df63b841998eb2'/>
<id>urn:sha1:359f482533ebf0c974eabbcc83df63b841998eb2</id>
<content type='text'>
into ppc970.osdl.org:/home/torvalds/v2.6/linux

Manual merge of kernel/params.c clashes.
</content>
</entry>
</feed>
