include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

2010-03-30T13:02:32Z

percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo Guess-its-ok-by: Christoph Lameter Cc: Ingo Molnar Cc: Lee Schermerhorn

pkt_sched: remove unnecessary xchg() in packet classifiers

2008-11-20T12:14:28Z

The use of xchg() hasn't been necessary since 2.2.something when proper locking was added to packet schedulers. In the case of classifiers they mostly weren't even necessary before that since they're mainly used to assign a NULL pointer to the filter root in the ->destroy path; the root is destroyed immediately after that. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: Constify struct tcf_ext_map

2008-02-01T03:28:34Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: Use nla_policy for attribute validation in classifiers

2008-01-28T23:11:23Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: Use typeful attribute parsing helpers

2008-01-28T23:11:21Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: Use typeful attribute construction helpers

2008-01-28T23:11:20Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: Use nla_nest_start/nla_nest_end

2008-01-28T23:11:18Z

Use nla_nest_start/nla_nest_end for dumping nested attributes. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: Propagate nla_parse return value

2008-01-28T23:11:18Z

nla_parse() returns more detailed errno codes, propagate them back on error. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: Convert classifiers from rtnetlink to new netlink API

2008-01-28T23:11:11Z

Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

[NET_SCHED]: mark classifier ops __read_mostly

2008-01-28T23:11:08Z

Additionally remove unnecessary NULL initilizations of the next pointer. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller

user/sven/linux.git/net/sched/cls_basic.c, branch ipvs/cleanups

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

pkt_sched: remove unnecessary xchg() in packet classifiers

[NET_SCHED]: Constify struct tcf_ext_map

[NET_SCHED]: Use nla_policy for attribute validation in classifiers

[NET_SCHED]: Use typeful attribute parsing helpers

[NET_SCHED]: Use typeful attribute construction helpers

[NET_SCHED]: Use nla_nest_start/nla_nest_end

[NET_SCHED]: Propagate nla_parse return value

[NET_SCHED]: Convert classifiers from rtnetlink to new netlink API

[NET_SCHED]: mark classifier ops __read_mostly