user/sven/linux.git/scripts/headerdep.pl, branch v3.7Linux Kernel
https://git.stealer.net/cgit.cgi/user/sven/linux.git/atom?h=v3.72010-03-23T11:26:38Zheaderdep: perlcritic warning2010-03-23T11:26:38ZStephen Hemmingershemminger@vyatta.com2010-03-08T16:24:27Zurn:sha1:1dcd81002453f9f22c6c4fd6c3c7d8f1c7c891fa
Minor perlcritic warning:
headerdep.pl: "return" statement with explicit "undef" at line 84, column 2. See page 199 of PBP. (Severity: 5)
The rationale according to PBP is that an explicit return of undef
(contrary to most people's expectations) doesn't
always evaluate as false. It has to with the fact that perl return value
depends on context the function is called. If function is used in
list context, the appropriate return value for false is an empty list;
whereas in scalar context the return value for false is undefined.
By just using a "return" both cases are handled.
In the context of a trivial script this doesn't matter. But one script
may be cut-paste into later code (most people like me only know 50%
of perl), that is why perlcritic always complains
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
kbuild: fix option processing for -I in headerdep2009-04-11T06:18:07ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2009-03-29T13:01:47Zurn:sha1:79ff807cf23ffb527f3f35bdececf56cabcdee07
-I takes an argument. Without this change only a 1 is added to
@opt_include which is not helpful.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
kbuild: add headerdep used to detect inclusion cycles in header files2008-12-18T19:18:04ZVegard Nossumvegard.nossum@gmail.com2008-12-16T11:33:43Zurn:sha1:179efcb47d5a5dd34a45be3f0eca4bffa717c6b4
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>