From caede697c7157710af6fb14da376e05ab120659c Mon Sep 17 00:00:00 2001 From: Martin Dalecki Date: Thu, 13 Jun 2002 19:49:33 -0700 Subject: [PATCH] 2.5.21 IDE 89 - fix lock initialization for device tree handling. Well I would be lucky if it would be just a device tree like in Solaris. But after studying the code which goes in right now it appears to develop quite fast in to a "just in case" and "ad-hoc" inferface mess we have already in /proc. Shit! Look for example at the initialization of a device struct. First we have a name to the directory encompassing the device and the immediately we fill in the georgeous name field - which is enterly unnecessary. - Pull locking out from the device type drivers do_request handlers. This allowed us to remove the draddy unlocking on entry to start_request. Much more of host controller rigister acces on crutial code paths is now covered by the queue access lock. --- include/linux/ide.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'include/linux') diff --git a/include/linux/ide.h b/include/linux/ide.h index 51fbd637a48a..47cbaea890a8 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -357,7 +357,7 @@ struct ata_device { byte queue_depth; /* max queue depth */ unsigned int failures; /* current failure count */ unsigned int max_failures; /* maximum allowed failure count */ - struct device device; /* global device tree handle */ + struct device dev; /* global device tree handle */ /* * tcq statistics @@ -545,7 +545,7 @@ struct ata_operations { void (*attach) (struct ata_device *); int (*cleanup)(struct ata_device *); int (*standby)(struct ata_device *); - ide_startstop_t (*do_request)(struct ata_device *, struct request *, sector_t); + ide_startstop_t (*XXX_do_request)(struct ata_device *, struct request *, sector_t); int (*end_request)(struct ata_device *, struct request *, int); int (*ioctl)(struct ata_device *, struct inode *, struct file *, unsigned int, unsigned long); -- cgit v1.2.3