From ca61a009a128ed6c0aaa00f9bd444deb54db1eaa Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Sun, 29 Sep 2002 02:19:51 -0700 Subject: [PATCH] additional might_sleep checks - Dave says that lock_sock() inside locks is a popular bug. Put a check there. - Also in wait_for_completion(). - Add the text "Debug" to the warning message so people are less likely to think that they've oopsed. --- kernel/sched.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'kernel') diff --git a/kernel/sched.c b/kernel/sched.c index 44d4929ca677..aa13d6a55721 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -1163,6 +1163,7 @@ void complete(struct completion *x) void wait_for_completion(struct completion *x) { + might_sleep(); spin_lock_irq(&x->wait.lock); if (!x->done) { DECLARE_WAITQUEUE(wait, current); @@ -2158,7 +2159,7 @@ void __might_sleep(char *file, int line) if (time_before(jiffies, prev_jiffy + HZ)) return; prev_jiffy = jiffies; - printk("Sleeping function called from illegal" + printk(KERN_ERR "Debug: sleeping function called from illegal" " context at %s:%d\n", file, line); dump_stack(); } -- cgit v1.2.3