summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMikeTeachman <mike.teachman@gmail.com>2021-09-24 20:06:10 -0700
committerDamien George <damien@micropython.org>2021-11-12 16:50:15 +1100
commit0be3b91f11e81ff18a0554c31326ac9df20a2091 (patch)
tree5c61e6c01b4e4727349ad3c5a69baac6a2154374
parent6d9da27c21bcc687f868d77ffca42e4dfc234248 (diff)
stm32,esp32: In machine_i2s, send null samples in underflow situations.
Eliminate noise data from being sent to the I2S peripheral when the transmitted sample stream is stopped. Signed-off-by: Mike Teachman <mike.teachman@gmail.com>
-rw-r--r--ports/esp32/machine_i2s.c1
-rw-r--r--ports/stm32/machine_i2s.c3
2 files changed, 4 insertions, 0 deletions
diff --git a/ports/esp32/machine_i2s.c b/ports/esp32/machine_i2s.c
index dc583e8e9..390b01e5e 100644
--- a/ports/esp32/machine_i2s.c
+++ b/ports/esp32/machine_i2s.c
@@ -448,6 +448,7 @@ STATIC void machine_i2s_init_helper(machine_i2s_obj_t *self, size_t n_pos_args,
i2s_config.dma_buf_count = get_dma_buf_count(mode, bits, format, self->ibuf);
i2s_config.dma_buf_len = DMA_BUF_LEN_IN_I2S_FRAMES;
i2s_config.use_apll = false;
+ i2s_config.tx_desc_auto_clear = true;
// I2S queue size equals the number of DMA buffers
check_esp_err(i2s_driver_install(self->port, &i2s_config, i2s_config.dma_buf_count, &self->i2s_event_queue));
diff --git a/ports/stm32/machine_i2s.c b/ports/stm32/machine_i2s.c
index 32167cf4e..266dd45e8 100644
--- a/ports/stm32/machine_i2s.c
+++ b/ports/stm32/machine_i2s.c
@@ -509,6 +509,9 @@ STATIC void feed_dma(machine_i2s_obj_t *self, ping_pong_t dma_ping_pong) {
if (self->bits == 32) {
reformat_32_bit_samples((int32_t *)dma_buffer_p, SIZEOF_HALF_DMA_BUFFER_IN_BYTES / (sizeof(uint32_t)));
}
+ } else {
+ // underflow. clear buffer to transmit "silence" on the I2S bus
+ memset(dma_buffer_p, 0, SIZEOF_HALF_DMA_BUFFER_IN_BYTES);
}
// flush cache to RAM so DMA can read the sample data