summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDamien George <damien@micropython.org>2021-06-17 12:22:18 +1000
committerDamien George <damien@micropython.org>2021-06-17 14:54:04 +1000
commit8107c9b75bb5b4936fe68edaa6f65fb3de8904bc (patch)
tree790a547c2dbe46c6d8e6f48ce57b60a2aa1dabf8
parent514bf1a1911ac9173a00820b7e09dfb387e6b941 (diff)
extmod/nimble: Remove TODO comment about notify_custom freeing om.
The comments in NimBLE for ble_gattc_notify_custom() state that "This function consumes the supplied mbuf regardless of the outcome.". And inspection of NimBLE code shows that this is the case. So the comment can be removed. Signed-off-by: Damien George <damien@micropython.org>
-rw-r--r--extmod/nimble/modbluetooth_nimble.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/extmod/nimble/modbluetooth_nimble.c b/extmod/nimble/modbluetooth_nimble.c
index e3a2f872e..f4b9ccb60 100644
--- a/extmod/nimble/modbluetooth_nimble.c
+++ b/extmod/nimble/modbluetooth_nimble.c
@@ -1030,7 +1030,6 @@ int mp_bluetooth_gatts_notify_send(uint16_t conn_handle, uint16_t value_handle,
if (om == NULL) {
return MP_ENOMEM;
}
- // TODO: check that notify_custom takes ownership of om, if not os_mbuf_free_chain(om).
return ble_hs_err_to_errno(ble_gattc_notify_custom(conn_handle, value_handle, om));
}