diff options
| author | Damien George <damien@micropython.org> | 2020-09-12 13:47:59 +1000 |
|---|---|---|
| committer | Damien George <damien@micropython.org> | 2020-09-12 13:47:59 +1000 |
| commit | b31cb21a3936b97af4a52b082e1f40c2061aeab7 (patch) | |
| tree | d94daef4716eebb7e15d09113ce59a9602560170 | |
| parent | acdb0608b7622cc7af0bdbfc89b2696583c948ae (diff) | |
stm32/servo: Fix angle and speed methods to work again with -ve args.
Fixes a regression introduced by 70affd9ba22e7f62666a9a2fafc2a3c0be9ef95a
Fixes issue #6403
Signed-off-by: Damien George <damien@micropython.org>
| -rw-r--r-- | ports/stm32/servo.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ports/stm32/servo.c b/ports/stm32/servo.c index a347c6bbd..170842246 100644 --- a/ports/stm32/servo.c +++ b/ports/stm32/servo.c @@ -278,7 +278,7 @@ STATIC mp_obj_t pyb_servo_angle(size_t n_args, const mp_obj_t *args) { return mp_obj_new_int((self->pulse_cur - self->pulse_centre) * 90 / self->pulse_angle_90); } else { #if MICROPY_PY_BUILTINS_FLOAT - self->pulse_dest = self->pulse_centre + (uint16_t)((mp_float_t)self->pulse_angle_90 * mp_obj_get_float(args[1]) / MICROPY_FLOAT_CONST(90.0)); + self->pulse_dest = self->pulse_centre + (int16_t)((mp_float_t)self->pulse_angle_90 * mp_obj_get_float(args[1]) / MICROPY_FLOAT_CONST(90.0)); #else self->pulse_dest = self->pulse_centre + self->pulse_angle_90 * mp_obj_get_int(args[1]) / 90; #endif @@ -308,7 +308,7 @@ STATIC mp_obj_t pyb_servo_speed(size_t n_args, const mp_obj_t *args) { return mp_obj_new_int((self->pulse_cur - self->pulse_centre) * 100 / self->pulse_speed_100); } else { #if MICROPY_PY_BUILTINS_FLOAT - self->pulse_dest = self->pulse_centre + (uint16_t)((mp_float_t)self->pulse_speed_100 * mp_obj_get_float(args[1]) / MICROPY_FLOAT_CONST(100.0)); + self->pulse_dest = self->pulse_centre + (int16_t)((mp_float_t)self->pulse_speed_100 * mp_obj_get_float(args[1]) / MICROPY_FLOAT_CONST(100.0)); #else self->pulse_dest = self->pulse_centre + self->pulse_speed_100 * mp_obj_get_int(args[1]) / 100; #endif |