diff options
| author | Damien George <damien.p.george@gmail.com> | 2015-04-09 23:56:15 +0100 |
|---|---|---|
| committer | Damien George <damien.p.george@gmail.com> | 2015-04-16 14:30:16 +0000 |
| commit | 7f9d1d6ab923096582622b700bedb6a571518eac (patch) | |
| tree | f97a0d56ba0279dd4ef2a44f00676193c4d49d8b /cc3200/mods/pybpin.c | |
| parent | 56beb01724d4f0027babc5d23f016efbde4c4190 (diff) | |
py: Overhaul and simplify printf/pfenv mechanism.
Previous to this patch the printing mechanism was a bit of a tangled
mess. This patch attempts to consolidate printing into one interface.
All (non-debug) printing now uses the mp_print* family of functions,
mainly mp_printf. All these functions take an mp_print_t structure as
their first argument, and this structure defines the printing backend
through the "print_strn" function of said structure.
Printing from the uPy core can reach the platform-defined print code via
two paths: either through mp_sys_stdout_obj (defined pert port) in
conjunction with mp_stream_write; or through the mp_plat_print structure
which uses the MP_PLAT_PRINT_STRN macro to define how string are printed
on the platform. The former is only used when MICROPY_PY_IO is defined.
With this new scheme printing is generally more efficient (less layers
to go through, less arguments to pass), and, given an mp_print_t*
structure, one can call mp_print_str for efficiency instead of
mp_printf("%s", ...). Code size is also reduced by around 200 bytes on
Thumb2 archs.
Diffstat (limited to 'cc3200/mods/pybpin.c')
| -rw-r--r-- | cc3200/mods/pybpin.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/cc3200/mods/pybpin.c b/cc3200/mods/pybpin.c index b8db31941..dbfc34866 100644 --- a/cc3200/mods/pybpin.c +++ b/cc3200/mods/pybpin.c @@ -429,14 +429,14 @@ STATIC mp_obj_t pin_obj_init_helper(pin_obj_t *self, mp_uint_t n_args, const mp_ /// \method print() /// Return a string describing the pin object. -STATIC void pin_print(void (*print)(void *env, const char *fmt, ...), void *env, mp_obj_t self_in, mp_print_kind_t kind) { +STATIC void pin_print(const mp_print_t *print, mp_obj_t self_in, mp_print_kind_t kind) { pin_obj_t *self = self_in; uint32_t af = MAP_PinModeGet(self->pin_num); uint32_t type = pin_get_type(self); uint32_t strength = pin_get_strenght(self); // pin name - print(env, "<Pin.cpu.%s, af=%u", qstr_str(self->name), af); + mp_printf(print, "<Pin.cpu.%s, af=%u", qstr_str(self->name), af); if (af == PIN_MODE_0) { // IO mode @@ -447,7 +447,7 @@ STATIC void pin_print(void (*print)(void *env, const char *fmt, ...), void *env, } else { mode_qst = MP_QSTR_OUT; } - print(env, ", mode=Pin.%s", qstr_str(mode_qst)); // safe because mode_qst has no formatting chars + mp_printf(print, ", mode=Pin.%s", qstr_str(mode_qst)); } // pin type @@ -465,7 +465,7 @@ STATIC void pin_print(void (*print)(void *env, const char *fmt, ...), void *env, } else { type_qst = MP_QSTR_OD_PD; } - print(env, ", pull=Pin.%s", qstr_str(type_qst)); + mp_printf(print, ", pull=Pin.%s", qstr_str(type_qst)); // Strength qstr str_qst; @@ -476,7 +476,7 @@ STATIC void pin_print(void (*print)(void *env, const char *fmt, ...), void *env, } else { str_qst = MP_QSTR_S6MA; } - print(env, ", strength=Pin.%s>", qstr_str(str_qst)); + mp_printf(print, ", strength=Pin.%s>", qstr_str(str_qst)); } /// \classmethod \constructor(id, ...) |
