diff options
| author | Jon Bjarni Bjarnason <jbbjarnason@gmail.com> | 2022-02-16 11:44:17 -0500 |
|---|---|---|
| committer | Damien George <damien@micropython.org> | 2022-04-11 15:26:47 +1000 |
| commit | 919f696ad254bcc39effe7ce7fddae8cf406c954 (patch) | |
| tree | 38a132ffc829eb7888009f72e547ecf2d30058af /ports/esp32/modsocket.c | |
| parent | d3d862769ad9f1317702b921dda1912d9a673948 (diff) | |
extmod/modusocket: Implement optional socket.listen backlog argument.
This follows the CPython change: https://bugs.python.org/issue21455
Socket listen backlog defaults to 2 if not given, based on most bare metal
targets not having many resources for a large backlog. On UNIX it defaults
to SOMAXCONN or 128, whichever is less.
Diffstat (limited to 'ports/esp32/modsocket.c')
| -rw-r--r-- | ports/esp32/modsocket.c | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/ports/esp32/modsocket.c b/ports/esp32/modsocket.c index be950ac1f..d1abe3fbc 100644 --- a/ports/esp32/modsocket.c +++ b/ports/esp32/modsocket.c @@ -295,9 +295,16 @@ STATIC mp_obj_t socket_bind(const mp_obj_t arg0, const mp_obj_t arg1) { } STATIC MP_DEFINE_CONST_FUN_OBJ_2(socket_bind_obj, socket_bind); -STATIC mp_obj_t socket_listen(const mp_obj_t arg0, const mp_obj_t arg1) { - socket_obj_t *self = MP_OBJ_TO_PTR(arg0); - int backlog = mp_obj_get_int(arg1); +// method socket.listen([backlog]) +STATIC mp_obj_t socket_listen(size_t n_args, const mp_obj_t *args) { + socket_obj_t *self = MP_OBJ_TO_PTR(args[0]); + + int backlog = 2; + if (n_args > 1) { + backlog = mp_obj_get_int(args[1]); + backlog = (backlog < 0) ? 0 : backlog; + } + self->state = SOCKET_STATE_CONNECTED; int r = lwip_listen(self->fd, backlog); if (r < 0) { @@ -305,7 +312,7 @@ STATIC mp_obj_t socket_listen(const mp_obj_t arg0, const mp_obj_t arg1) { } return mp_const_none; } -STATIC MP_DEFINE_CONST_FUN_OBJ_2(socket_listen_obj, socket_listen); +STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(socket_listen_obj, 1, 2, socket_listen); STATIC mp_obj_t socket_accept(const mp_obj_t arg0) { socket_obj_t *self = MP_OBJ_TO_PTR(arg0); |
