summaryrefslogtreecommitdiff
path: root/py/objint_longlong.c
diff options
context:
space:
mode:
authorYoctopuce dev <dev@yoctopuce.com>2025-07-21 15:54:27 +0200
committerDamien George <damien@micropython.org>2025-07-29 00:27:01 +1000
commit3c69277ba9e0f1e66c341c084320f7a763e1bdeb (patch)
treec59665c537c54d48edd6817257d5b180d22ea485 /py/objint_longlong.c
parent062e82a7cd60165db7edd8ee32105ea19a31ae2f (diff)
py/objint_longlong: Fix overflow check in mp_obj_int_get_checked.
This is to fix an outstanding TODO. The test cases is using a range as this will exist in all builds, but `mp_obj_get_int` is used in many different parts of code where an overflow is more likely to occur. Signed-off-by: Yoctopuce dev <dev@yoctopuce.com>
Diffstat (limited to 'py/objint_longlong.c')
-rw-r--r--py/objint_longlong.c13
1 files changed, 11 insertions, 2 deletions
diff --git a/py/objint_longlong.c b/py/objint_longlong.c
index 339ce7cfd..8b8fdc62e 100644
--- a/py/objint_longlong.c
+++ b/py/objint_longlong.c
@@ -308,8 +308,17 @@ mp_int_t mp_obj_int_get_truncated(mp_const_obj_t self_in) {
}
mp_int_t mp_obj_int_get_checked(mp_const_obj_t self_in) {
- // TODO: Check overflow
- return mp_obj_int_get_truncated(self_in);
+ if (mp_obj_is_small_int(self_in)) {
+ return MP_OBJ_SMALL_INT_VALUE(self_in);
+ } else {
+ const mp_obj_int_t *self = self_in;
+ long long value = self->val;
+ mp_int_t truncated = (mp_int_t)value;
+ if ((long long)truncated == value) {
+ return truncated;
+ }
+ }
+ mp_raise_msg(&mp_type_OverflowError, MP_ERROR_TEXT("overflow converting long int to machine word"));
}
mp_uint_t mp_obj_int_get_uint_checked(mp_const_obj_t self_in) {