diff options
| author | Jeff Epler <jepler@gmail.com> | 2025-06-13 17:24:08 +0200 |
|---|---|---|
| committer | Damien George <damien@micropython.org> | 2025-06-17 10:15:59 +1000 |
| commit | b6b7d64bd9257cc1c138d37033108dcff5ceb89e (patch) | |
| tree | 34cbfaaeec6a62bf98b9d6be82668c15351f391f /py | |
| parent | 5ade8b7058f95e77a0d62d523c8443647f176532 (diff) | |
py/modio: Fix the case where write fails in BufferedWriter.flush.
Previously, there was no test coverage of the "write failed" path. In
fact, the assertion would fire instead of gracefully raising a Python
exception.
Slightly re-organize the code to place the assertion later. Add a test
case which exercises all paths, and update the expected output.
Signed-off-by: Jeff Epler <jepler@gmail.com>
Diffstat (limited to 'py')
| -rw-r--r-- | py/modio.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/py/modio.c b/py/modio.c index d3e563dbc..9aeb42d30 100644 --- a/py/modio.c +++ b/py/modio.c @@ -169,12 +169,13 @@ static mp_obj_t bufwriter_flush(mp_obj_t self_in) { int err; mp_uint_t out_sz = mp_stream_write_exactly(self->stream, self->buf, self->len, &err); (void)out_sz; - // TODO: try to recover from a case of non-blocking stream, e.g. move - // remaining chunk to the beginning of buffer. - assert(out_sz == self->len); - self->len = 0; if (err != 0) { mp_raise_OSError(err); + } else { + // TODO: try to recover from a case of non-blocking stream, e.g. move + // remaining chunk to the beginning of buffer. + assert(out_sz == self->len); + self->len = 0; } } |
