From 9b196cddab80e24b9ce66b1c922cb757b11fb16a Mon Sep 17 00:00:00 2001 From: Damien George Date: Wed, 26 Mar 2014 21:47:19 +0000 Subject: Remove mp_obj_type_t.methods entry and use .locals_dict instead. Originally, .methods was used for methods in a ROM class, and locals_dict for methods in a user-created class. That distinction is unnecessary, and we can use locals_dict for ROM classes now that we have ROMable maps. This removes an entry in the bloated mp_obj_type_t struct, saving a word for each ROM object and each RAM object. ROM objects that have a methods table (now a locals_dict) need an extra word in total (removed the methods pointer (1 word), no longer need the sentinel (2 words), but now need an mp_obj_dict_t wrapper (4 words)). But RAM objects save a word because they never used the methods entry. Overall the ROM usage is down by a few hundred bytes, and RAM usage is down 1 word per user-defined type/class. There is less code (no need to check 2 tables), and now consistent with the way ROM modules have their tables initialised. Efficiency is very close to equivaluent. --- unix/socket.c | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) (limited to 'unix/socket.c') diff --git a/unix/socket.c b/unix/socket.c index 85e59b284..312554428 100644 --- a/unix/socket.c +++ b/unix/socket.c @@ -15,6 +15,7 @@ #include "mpconfig.h" #include "qstr.h" #include "obj.h" +#include "map.h" #include "objtuple.h" #include "objarray.h" #include "runtime.h" @@ -217,28 +218,29 @@ static mp_obj_t socket_make_new(mp_obj_t type_in, uint n_args, uint n_kw, const return socket_new(fd); } -static const mp_method_t microsocket_type_methods[] = { - { MP_QSTR_fileno, &socket_fileno_obj }, - { MP_QSTR_makefile, &mp_identity_obj }, - { MP_QSTR_read, &mp_stream_read_obj }, - { MP_QSTR_readall, &mp_stream_readall_obj }, - { MP_QSTR_readline, &mp_stream_unbuffered_readline_obj}, - { MP_QSTR_write, &mp_stream_write_obj }, - { MP_QSTR_connect, &socket_connect_obj }, - { MP_QSTR_bind, &socket_bind_obj }, - { MP_QSTR_listen, &socket_listen_obj }, - { MP_QSTR_accept, &socket_accept_obj }, - { MP_QSTR_recv, &socket_recv_obj }, - { MP_QSTR_send, &socket_send_obj }, - { MP_QSTR_setsockopt, &socket_setsockopt_obj }, - { MP_QSTR_close, &socket_close_obj }, +static const mp_map_elem_t microsocket_locals_dict_table[] = { + { MP_OBJ_NEW_QSTR(MP_QSTR_fileno), (mp_obj_t)&socket_fileno_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_makefile), (mp_obj_t)&mp_identity_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_read), (mp_obj_t)&mp_stream_read_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_readall), (mp_obj_t)&mp_stream_readall_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_readline), (mp_obj_t)&mp_stream_unbuffered_readline_obj}, + { MP_OBJ_NEW_QSTR(MP_QSTR_write), (mp_obj_t)&mp_stream_write_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_connect), (mp_obj_t)&socket_connect_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_bind), (mp_obj_t)&socket_bind_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_listen), (mp_obj_t)&socket_listen_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_accept), (mp_obj_t)&socket_accept_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_recv), (mp_obj_t)&socket_recv_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_send), (mp_obj_t)&socket_send_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_setsockopt), (mp_obj_t)&socket_setsockopt_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_close), (mp_obj_t)&socket_close_obj }, #if MICROPY_SOCKET_EXTRA - { MP_QSTR_recv, &mp_stream_read_obj }, - { MP_QSTR_send, &mp_stream_write_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_recv), (mp_obj_t)&mp_stream_read_obj }, + { MP_OBJ_NEW_QSTR(MP_QSTR_send), (mp_obj_t)&mp_stream_write_obj }, #endif - { MP_QSTR_NULL, NULL }, }; +STATIC MP_DEFINE_CONST_DICT(microsocket_locals_dict, microsocket_locals_dict_table); + static const mp_obj_type_t microsocket_type = { { &mp_type_type }, .name = MP_QSTR_socket, @@ -250,7 +252,7 @@ static const mp_obj_type_t microsocket_type = { .read = socket_read, .write = socket_write, }, - .methods = microsocket_type_methods, + .locals_dict = (mp_obj_t)µsocket_locals_dict, }; static mp_obj_t mod_socket_htons(mp_obj_t arg) { -- cgit v1.2.3