user/sven/openrc.git/src/openrc, branch github/master

rc: fix automatic restart with runlevel-specific conf.d files

2023-07-27T03:41:42Z

Commit fc4f15d6cd8e7884f7094e5d3749b01f2d5a448f broke the automatic restart of services having runlevel-specific conf.d files. The double dirname() was not a mistake, but the way of getting from the service script in init.d to the upper directory containing the conf.d directory. dirname() modifies the argument in-place, so the second call operated on a modified value. To make it more obvious what is going on, have the second call operate on the returned value from the first call. Fixes: fc4f15d ("openrc: fix double-assignment to dir") Signed-off-by: Sven Wegener

rc: use LIST_FOREACH_SAFE in cleanup()

2023-04-25T00:20:19Z

according to the linux manpage, the "safe" variant may not be available on all platform. however we bundle our own `queue.h` so this should not be an issue.

rc: block SIGCHLD during pid list operations

2023-04-25T00:20:19Z

the pid list will be accessed inside the SIGCHLD signal handler. so we must ensure SIGCHLD handler doesn't get invoked while the list is at an inconsistent state making it unsafe to interact with. Co-authored-by: Dominique MARTINET Bug: https://github.com/OpenRC/openrc/issues/589#issuecomment-1406588576

rc: avoid calling free inside SIGCHLD handler

2023-04-25T00:20:19Z

`free` is not async-signal-safe and calling it inside a signal handler can have bad effects, as reported in the musl ML: https://www.openwall.com/lists/musl/2023/01/23/1 the solution: - keep track of weather remove_pid() is being called from inside a signal handler or not. - if it's inside a signal handler then DO NOT call free - instead put that pointer into a "to be freed later" list. - if it's not inside a signal handler then take the "to be freed later" list and free anything in it. Bug: https://github.com/OpenRC/openrc/issues/589 Reported-by: Dominique MARTINET

Rename attribute macros to namespaced RC_*

2023-04-19T20:44:51Z

This conflicts with linux-headers which uses __unused for some padding members on ppc64le at least. Closes: https://github.com/OpenRC/openrc/issues/622

openrc: missing includes from IWYU

2023-01-29T17:32:22Z

openrc: rc-logger: add missing includes to header

2023-01-29T04:14:30Z

Needed for clang-tidy prep work, as it requires headers to work standalone (which is useful anyway).

openrc: avoid unnecessary malloc inside sig-handler

2023-01-28T18:08:00Z

malloc (called by xasprintf) is not async-signal-safe. beside, the string here is constant, so there's no need to malloc it all. eerrorx isn't async-signal-safe either (due to calling fprintf and exit) but consequence of them are _typically_ not as grave as calling malloc while it's internal state is inconsistent. Bug: https://github.com/OpenRC/openrc/issues/589

openrc: mark handle_bad_signal as noreturn

2023-01-25T05:51:13Z

For -Wmissing-noreturn.

openrc: fix double-assignment to dir

2023-01-25T05:05:32Z

This one is a bit odd, it didn't get fixed in e273b4e08ee0ebc1a001d60e2a5b65a9553a8a8a, and goes all the way back to cb9da6a262b60255cd037f20b4cde3ab2c8a1e6a.