summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Eisentraut <peter@eisentraut.org>2025-10-01 17:13:52 +0200
committerPeter Eisentraut <peter@eisentraut.org>2025-10-01 17:13:52 +0200
commit3e908fb54ff8fa857180bc212ca79c7bd95dcc2c (patch)
treed9a8108598382511e5f6c287774b640c6015bfa6
parent3a661580685964dd2ca192306a202934f268fc5c (diff)
Fix compiler warnings around _CRT_glob
Newer compilers warned about extern int _CRT_glob = 0; which is indeed a mysterious C construction, as it combines "extern" and an initialization. It turns out that according to the C standard, the "extern" is ignored here, so we can remove it to resolve the warnings. But then we also need to add a real extern declaration (without initializer) to satisfy -Wmissing-variable-declarations. (Note that this code is only active on MinGW.) Discussion: https://www.postgresql.org/message-id/1053279b-da01-4eb4-b7a3-da6b5d8f73d1%40eisentraut.org
-rw-r--r--src/common/exec.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/common/exec.c b/src/common/exec.c
index 8b690a10185..cca89f04074 100644
--- a/src/common/exec.c
+++ b/src/common/exec.c
@@ -46,7 +46,8 @@
/* Inhibit mingw CRT's auto-globbing of command line arguments */
#if defined(WIN32) && !defined(_MSC_VER)
-extern int _CRT_glob = 0; /* 0 turns off globbing; 1 turns it on */
+extern int _CRT_glob;
+int _CRT_glob = 0; /* 0 turns off globbing; 1 turns it on */
#endif
/*