diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-03-12 13:38:49 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-03-12 13:38:49 -0400 |
| commit | 590fc5d96f8b880fd41c4992dab73ec47f90eca4 (patch) | |
| tree | 87fd750ba755c2259e3ec6f64ea320e2e794472d /contrib/btree_gist/btree_utils_num.c | |
| parent | ae67e81edb684165b8d9661d4455908b9db618d8 (diff) | |
Ensure tableoid reads correctly in EvalPlanQual-manufactured tuples.
The ROW_MARK_COPY path in EvalPlanQualFetchRowMarks() was just setting
tableoid to InvalidOid, I think on the assumption that the referenced
RTE must be a subquery or other case without a meaningful OID. However,
foreign tables also use this code path, and they do have meaningful
table OIDs; so failure to set the tuple field can lead to user-visible
misbehavior. Fix that by fetching the appropriate OID from the range
table.
There's still an issue about whether CTID can ever have a meaningful
value in this case; at least with postgres_fdw foreign tables, it does.
But that is a different problem that seems to require a significantly
different patch --- it's debatable whether postgres_fdw really wants to
use this code path at all.
Simplified version of a patch by Etsuro Fujita, who also noted the
problem to begin with. The issue can be demonstrated in all versions
having FDWs, so back-patch to 9.1.
Diffstat (limited to 'contrib/btree_gist/btree_utils_num.c')
0 files changed, 0 insertions, 0 deletions
