diff options
| author | Michael Paquier <michael@paquier.xyz> | 2022-10-19 14:07:01 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2022-10-19 14:07:01 +0900 |
| commit | 5d2a47a2924240606ce1c57c98490fa41752ad41 (patch) | |
| tree | 0589dec2ad678a3ce0008d4497368139e7335871 /doc/src | |
| parent | 25fb9579bbb97c65d6b007c3de803c81abb4b240 (diff) | |
Rework shutdown callback of archiver modules
As currently designed, with a callback registered in a ERROR_CLEANUP
block, the shutdown callback would get called twice when updating
archive_library on SIGHUP, which is something that we want to avoid to
ease the life of extension writers.
Anyway, an ERROR in the archiver process is treated as a FATAL, stopping
it immediately, hence there is no need for a ERROR_CLEANUP block.
Instead of that, the shutdown callback is not called upon
before_shmem_exit(), giving to the modules the opportunity to do any
cleanup actions before the server shuts down its subsystems.
While on it, this commit adds some testing coverage for the shutdown
callback. Neither shell_archive nor basic_archive have been using it,
and one is added to shell_archive, whose trigger is checked in a TAP
test through a shutdown sequence.
Author: Nathan Bossart, Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13
Backpatch-through: 15
Diffstat (limited to 'doc/src')
| -rw-r--r-- | doc/src/sgml/config.sgml | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 099867dd1b7..703f6d5a7f4 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -3618,8 +3618,9 @@ include_dir 'conf.d' The library to use for archiving completed WAL file segments. If set to an empty string (the default), archiving via shell is enabled, and <xref linkend="guc-archive-command"/> is used. Otherwise, the specified - shared library is used for archiving. For more information, see - <xref linkend="backup-archiving-wal"/> and + shared library is used for archiving. The WAL archiver process is + restarted by the postmaster when this parameter changes. For more + information, see <xref linkend="backup-archiving-wal"/> and <xref linkend="archive-modules"/>. </para> <para> |