summaryrefslogtreecommitdiff
path: root/src/backend/access/hash/hashovfl.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2025-10-05 16:27:47 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2025-10-05 16:27:47 -0400
commit771b106d1994c494e341257aa4ed6e31dd9c2a45 (patch)
tree168dd366d10f4eeb662efb5af19e73b5b49fdcfd /src/backend/access/hash/hashovfl.c
parentb5cefc197e5d9587de62e00519eca68cbf3d83bc (diff)
Use SOCK_ERRNO[_SET] in fe-secure-gssapi.c.origin/REL_15_STABLE
On Windows, this code did not handle error conditions correctly at all, since it looked at "errno" which is not used for socket-related errors on that platform. This resulted, for example, in failure to connect to a PostgreSQL server with GSSAPI enabled. We have a convention for dealing with this within libpq, which is to use SOCK_ERRNO and SOCK_ERRNO_SET rather than touching errno directly; but the GSSAPI code is a relative latecomer and did not get that memo. (The equivalent backend code continues to use errno, because the backend does this differently. Maybe libpq's approach should be rethought someday.) Apparently nobody tries to build libpq with GSSAPI support on Windows, or we'd have heard about this before, because it's been broken all along. Back-patch to all supported branches. Author: Ning Wu <ning94803@gmail.com> Co-authored-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAFGqpvg-pRw=cdsUpKYfwY6D3d-m9tw8WMcAEE7HHWfm-oYWvw@mail.gmail.com Backpatch-through: 13
Diffstat (limited to 'src/backend/access/hash/hashovfl.c')
0 files changed, 0 insertions, 0 deletions