diff options
author | Alexander Korotkov <akorotkov@postgresql.org> | 2024-04-08 11:23:28 +0300 |
---|---|---|
committer | Alexander Korotkov <akorotkov@postgresql.org> | 2024-04-08 11:23:28 +0300 |
commit | 9bd99f4c26fe37b8ee2f199aa868a0e2fdba4c43 (patch) | |
tree | acbadc21922045fa7f729f5c199e4e33c30e2541 /src/backend/commands/createas.c | |
parent | 6f3d8d5e7cc2f2e2367cd6da6f8affe98d1f5729 (diff) |
Custom reloptions for table AM
Let table AM define custom reloptions for its tables. This allows specifying
AM-specific parameters by the WITH clause when creating a table.
The reloptions, which could be used outside of table AM, are now extracted
into the CommonRdOptions data structure. These options could be by decision
of table AM directly specified by a user or calculated in some way.
The new test module test_tam_options evaluates the ability to set up custom
reloptions and calculate fields of CommonRdOptions on their base.
The code may use some parts from prior work by Hao Wu.
Discussion: https://postgr.es/m/CAPpHfdurb9ycV8udYqM%3Do0sPS66PJ4RCBM1g-bBpvzUfogY0EA%40mail.gmail.com
Discussion: https://postgr.es/m/AMUA1wBBBxfc3tKRLLdU64rb.1.1683276279979.Hmail.wuhao%40hashdata.cn
Reviewed-by: Reviewed-by: Pavel Borisov, Matthias van de Meent, Jess Davis
Diffstat (limited to 'src/backend/commands/createas.c')
-rw-r--r-- | src/backend/commands/createas.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c index afd3dace079..c5df96e374a 100644 --- a/src/backend/commands/createas.c +++ b/src/backend/commands/createas.c @@ -85,6 +85,9 @@ create_ctas_internal(List *attrList, IntoClause *into) Datum toast_options; static char *validnsps[] = HEAP_RELOPT_NAMESPACES; ObjectAddress intoRelationAddr; + const TableAmRoutine *tableam = NULL; + Oid accessMethodId = InvalidOid; + Relation rel; /* This code supports both CREATE TABLE AS and CREATE MATERIALIZED VIEW */ is_matview = (into->viewQuery != NULL); @@ -125,7 +128,15 @@ create_ctas_internal(List *attrList, IntoClause *into) validnsps, true, false); - (void) heap_reloptions(RELKIND_TOASTVALUE, toast_options, true); + rel = relation_open(intoRelationAddr.objectId, AccessShareLock); + accessMethodId = table_relation_toast_am(rel); + relation_close(rel, AccessShareLock); + + if (OidIsValid(accessMethodId)) + { + tableam = GetTableAmRoutineByAmOid(accessMethodId); + (void) tableam_reloptions(tableam, RELKIND_TOASTVALUE, toast_options, NULL, true); + } NewRelationCreateToastTable(intoRelationAddr.objectId, toast_options); |