diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2006-09-19 22:49:53 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2006-09-19 22:49:53 +0000 |
| commit | b74c5436857cfd71a0f94736f19c9b070b053e24 (patch) | |
| tree | 366bedff3f9e7c5735cd9b7635b2566ffc90f0a6 /src/backend/optimizer/plan/initsplan.c | |
| parent | 45e11d098f7b9c611c47e0f8565f4aa88281c914 (diff) | |
Improve usage of effective_cache_size parameter by assuming that all the
tables in the query compete for cache space, not just the one we are
currently costing an indexscan for. This seems more realistic, and it
definitely will help in examples recently exhibited by Stefan
Kaltenbrunner. To get the total size of all the tables involved, we must
tweak the handling of 'append relations' a bit --- formerly we looked up
information about the child tables on-the-fly during set_append_rel_pathlist,
but it needs to be done before we start doing any cost estimation, so
push it into the add_base_rels_to_query scan.
Diffstat (limited to 'src/backend/optimizer/plan/initsplan.c')
| -rw-r--r-- | src/backend/optimizer/plan/initsplan.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/optimizer/plan/initsplan.c b/src/backend/optimizer/plan/initsplan.c index c2a1d3e080b..8299f6756b8 100644 --- a/src/backend/optimizer/plan/initsplan.c +++ b/src/backend/optimizer/plan/initsplan.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/optimizer/plan/initsplan.c,v 1.121 2006/09/08 17:49:13 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/optimizer/plan/initsplan.c,v 1.122 2006/09/19 22:49:52 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -76,8 +76,8 @@ static void check_hashjoinable(RestrictInfo *restrictinfo); * At the end of this process, there should be one baserel RelOptInfo for * every non-join RTE that is used in the query. Therefore, this routine * is the only place that should call build_simple_rel with reloptkind - * RELOPT_BASEREL. However, otherrels will be built later for append relation - * members. + * RELOPT_BASEREL. (Note: build_simple_rel recurses internally to build + * "other rel" RelOptInfos for the members of any appendrels we find here.) */ void add_base_rels_to_query(PlannerInfo *root, Node *jtnode) |