diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-04-19 18:51:03 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-04-19 18:51:03 -0400 |
| commit | ebcbc8cfe6c2d9c587ae2a25e545f09b58b666b0 (patch) | |
| tree | d203193d19a674f9dcbba0a8a5848e6ff31d9d0f /src/include/catalog/index.h | |
| parent | 1da9966230a30405ea5981403d4f4a9d83cb1ecb (diff) | |
Avoid changing an index's indcheckxmin horizon during REINDEX.
There can never be a need to push the indcheckxmin horizon forward, since
any HOT chains that are actually broken with respect to the index must
pre-date its original creation. So we can just avoid changing pg_index
altogether during a REINDEX operation.
This offers a cleaner solution than my previous patch for the problem
found a few days ago that we mustn't try to update pg_index while we are
reindexing it. System catalog indexes will always be created with
indcheckxmin = false during initdb, and with this modified code we should
never try to change their pg_index entries. This avoids special-casing
system catalogs as the former patch did, and should provide a performance
benefit for many cases where REINDEX formerly caused an index to be
considered unusable for a short time.
Back-patch to 8.3 to cover all versions containing HOT. Note that this
patch changes the API for index_build(), but I believe it is unlikely that
any add-on code is calling that directly.
Diffstat (limited to 'src/include/catalog/index.h')
| -rw-r--r-- | src/include/catalog/index.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/include/catalog/index.h b/src/include/catalog/index.h index 18f17037b7b..9728d791b6a 100644 --- a/src/include/catalog/index.h +++ b/src/include/catalog/index.h @@ -59,7 +59,8 @@ extern void FormIndexDatum(IndexInfo *indexInfo, extern void index_build(Relation heapRelation, Relation indexRelation, IndexInfo *indexInfo, - bool isprimary); + bool isprimary, + bool isreindex); extern double IndexBuildHeapScan(Relation heapRelation, Relation indexRelation, |