diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2010-12-08 20:01:14 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2010-12-08 20:01:14 -0500 |
| commit | 87eadd7e3d6f5581d5b4cb8083212a323050e388 (patch) | |
| tree | 3f700ffc1a43eddfcecffcd3e03ce462e20f64c3 /src/include/port/win32.h | |
| parent | 799d0b4b9ede51c629149185e4058c52117cd231 (diff) | |
Force default wal_sync_method to be fdatasync on Linux.
Recent versions of the Linux system header files cause xlogdefs.h to
believe that open_datasync should be the default sync method, whereas
formerly fdatasync was the default on Linux. open_datasync is a bad
choice, first because it doesn't actually outperform fdatasync (in fact
the reverse), and second because we try to use O_DIRECT with it, causing
failures on certain filesystems (e.g., ext4 with data=journal option).
This part of the patch is largely per a proposal from Marti Raudsepp.
More extensive changes are likely to follow in HEAD, but this is as much
change as we want to back-patch.
Also clean up confusing code and incorrect documentation surrounding the
fsync_writethrough option. Those changes shouldn't result in any actual
behavioral change, but I chose to back-patch them anyway to keep the
branches looking similar in this area.
In 9.0 and HEAD, also do some copy-editing on the WAL Reliability
documentation section.
Back-patch to all supported branches, since any of them might get used
on modern Linux versions.
Diffstat (limited to 'src/include/port/win32.h')
| -rw-r--r-- | src/include/port/win32.h | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/src/include/port/win32.h b/src/include/port/win32.h index 7338b115c46..1473d9e8c3c 100644 --- a/src/include/port/win32.h +++ b/src/include/port/win32.h @@ -34,14 +34,18 @@ /* Must be here to avoid conflicting with prototype in windows.h */ #define mkdir(a,b) mkdir(a) -#define HAVE_FSYNC_WRITETHROUGH -#define HAVE_FSYNC_WRITETHROUGH_ONLY #define ftruncate(a,b) chsize(a,b) + +/* Windows doesn't have fsync() as such, use _commit() */ +#define fsync(fd) _commit(fd) + /* - * Even though we don't support 'fsync' as a wal_sync_method, - * we do fsync() a few other places where _commit() is just fine. + * For historical reasons, we allow setting wal_sync_method to + * fsync_writethrough on Windows, even though it's really identical to fsync + * (both code paths wind up at _commit()). */ -#define fsync(fd) _commit(fd) +#define HAVE_FSYNC_WRITETHROUGH +#define FSYNC_WRITETHROUGH_IS_FSYNC #define USES_WINSOCK |