diff options
| author | Melanie Plageman <melanieplageman@gmail.com> | 2024-07-19 11:06:03 -0400 |
|---|---|---|
| committer | Melanie Plageman <melanieplageman@gmail.com> | 2024-07-19 12:05:51 -0400 |
| commit | dc6354c67017a3fe60744fcfe4936d14d72f2d7c (patch) | |
| tree | c55d029357a99b7c60f8659d57bd7d4fcea58521 /src/include | |
| parent | f39f3e0fbe9b323aba41cf8c258f17259ab69a85 (diff) | |
Ensure vacuum removes all visibly dead tuples older than OldestXmin
If vacuum fails to remove a tuple with xmax older than
VacuumCutoffs->OldestXmin and younger than GlobalVisState->maybe_needed,
it will loop infinitely in lazy_scan_prune(), which compares tuples'
visibility information to OldestXmin.
Starting in version 14, which uses GlobalVisState for visibility testing
during pruning, it is possible for GlobalVisState->maybe_needed to
precede OldestXmin if maybe_needed is forced to go backward while vacuum
is running. This can happen if a disconnected standby with a running
transaction older than VacuumCutoffs->OldestXmin reconnects to the
primary after vacuum initially calculates GlobalVisState and OldestXmin.
Fix this by having vacuum always remove tuples older than OldestXmin
during pruning. This is okay because the standby won't replay the tuple
removal until the tuple is removable. Thus, the worst that can happen is
a recovery conflict.
Fixes BUG# 17257
Back-patched in versions 14-17
Author: Melanie Plageman
Reviewed-by: Noah Misch, Peter Geoghegan, Robert Haas, Andres Freund, and Heikki Linnakangas
Discussion: https://postgr.es/m/CAAKRu_Y_NJzF4-8gzTTeaOuUL3CcGoXPjXcAHbTTygT8AyVqag%40mail.gmail.com
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/access/heapam.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/include/access/heapam.h b/src/include/access/heapam.h index abf62d9df79..50b9e729e63 100644 --- a/src/include/access/heapam.h +++ b/src/include/access/heapam.h @@ -185,6 +185,7 @@ extern TransactionId heap_index_delete_tuples(Relation rel, struct GlobalVisState; extern void heap_page_prune_opt(Relation relation, Buffer buffer); extern int heap_page_prune(Relation relation, Buffer buffer, + TransactionId oldest_xmin, struct GlobalVisState *vistest, TransactionId old_snap_xmin, TimestampTz old_snap_ts_ts, |