diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-06-10 12:27:27 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-06-10 12:27:27 -0400 |
commit | 6e43f1c2df3da18b9d7087edddaf72dec84cfaf4 (patch) | |
tree | 5c74c85ec3bade1f3f336c4f426a197dfacbb5b7 /src/tools/git-external-diff | |
parent | 3465328aa19e363f3248839bea4521793940ad34 (diff) |
Rearrange logrep worker's snapshot handling some more.
It turns out that worker.c's code path for TRUNCATE was also
careless about establishing a snapshot while executing user-defined
code, allowing the checks added by commit 84f5c2908 to fail when
a trigger is fired in that context.
We could just wrap Push/PopActiveSnapshot around the truncate call,
but it seems better to establish a policy of holding a snapshot
throughout execution of a replication step. To help with that and
possible future requirements, replace the previous ensure_transaction
calls with pairs of begin/end_replication_step calls.
Per report from Mark Dilger. Back-patch to v11, like the previous
changes.
Discussion: https://postgr.es/m/B4A3AF82-79ED-4F4C-A4E5-CD2622098972@enterprisedb.com
Diffstat (limited to 'src/tools/git-external-diff')
0 files changed, 0 insertions, 0 deletions