diff options
Diffstat (limited to 'src/backend/optimizer')
-rw-r--r-- | src/backend/optimizer/plan/createplan.c | 9 | ||||
-rw-r--r-- | src/backend/optimizer/plan/planner.c | 2 | ||||
-rw-r--r-- | src/backend/optimizer/util/relnode.c | 36 |
3 files changed, 45 insertions, 2 deletions
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c index fda4df64210..bdac0b1860b 100644 --- a/src/backend/optimizer/plan/createplan.c +++ b/src/backend/optimizer/plan/createplan.c @@ -2152,6 +2152,15 @@ create_foreignscan_plan(PlannerInfo *root, ForeignPath *best_path, scan_plan->fs_relids = best_path->path.parent->relids; /* + * If a join between foreign relations was pushed down, remember it. The + * push-down safety of the join depends upon the server and user mapping + * being same. That can change between planning and execution time, in which + * case the plan should be invalidated. + */ + if (scan_relid == 0) + root->glob->hasForeignJoin = true; + + /* * Replace any outer-relation variables with nestloop params in the qual, * fdw_exprs and fdw_recheck_quals expressions. We do this last so that * the FDW doesn't have to be involved. (Note that parts of fdw_exprs diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c index c0ec905eb3f..a09b4b5b479 100644 --- a/src/backend/optimizer/plan/planner.c +++ b/src/backend/optimizer/plan/planner.c @@ -200,6 +200,7 @@ standard_planner(Query *parse, int cursorOptions, ParamListInfo boundParams) glob->lastPlanNodeId = 0; glob->transientPlan = false; glob->hasRowSecurity = false; + glob->hasForeignJoin = false; /* * Assess whether it's feasible to use parallel mode for this query. We @@ -346,6 +347,7 @@ standard_planner(Query *parse, int cursorOptions, ParamListInfo boundParams) result->nParamExec = glob->nParamExec; result->hasRowSecurity = glob->hasRowSecurity; result->parallelModeNeeded = glob->parallelModeNeeded; + result->hasForeignJoin = glob->hasForeignJoin; return result; } diff --git a/src/backend/optimizer/util/relnode.c b/src/backend/optimizer/util/relnode.c index 7428c18af9f..420692f7a4d 100644 --- a/src/backend/optimizer/util/relnode.c +++ b/src/backend/optimizer/util/relnode.c @@ -14,6 +14,9 @@ */ #include "postgres.h" +#include "miscadmin.h" +#include "catalog/pg_class.h" +#include "foreign/foreign.h" #include "optimizer/clauses.h" #include "optimizer/cost.h" #include "optimizer/pathnode.h" @@ -127,6 +130,7 @@ build_simple_rel(PlannerInfo *root, int relid, RelOptKind reloptkind) rel->subroot = NULL; rel->subplan_params = NIL; rel->serverid = InvalidOid; + rel->umid = InvalidOid; rel->fdwroutine = NULL; rel->fdw_private = NULL; rel->baserestrictinfo = NIL; @@ -166,6 +170,26 @@ build_simple_rel(PlannerInfo *root, int relid, RelOptKind reloptkind) break; } + /* For foreign tables get the user mapping */ + if (rte->relkind == RELKIND_FOREIGN_TABLE) + { + /* + * This should match what ExecCheckRTEPerms() does. + * + * Note that if the plan ends up depending on the user OID in any + * way - e.g. if it depends on the computed user mapping OID - we must + * ensure that it gets invalidated in the case of a user OID change. + * See RevalidateCachedQuery and more generally the hasForeignJoin + * flags in PlannerGlobal and PlannedStmt. + */ + Oid userid; + + userid = OidIsValid(rte->checkAsUser) ? rte->checkAsUser : GetUserId(); + rel->umid = GetUserMappingId(userid, rel->serverid); + } + else + rel->umid = InvalidOid; + /* Save the finished struct in the query's simple_rel_array */ root->simple_rel_array[relid] = rel; @@ -398,6 +422,7 @@ build_join_rel(PlannerInfo *root, joinrel->subroot = NULL; joinrel->subplan_params = NIL; joinrel->serverid = InvalidOid; + joinrel->umid = InvalidOid; joinrel->fdwroutine = NULL; joinrel->fdw_private = NULL; joinrel->baserestrictinfo = NIL; @@ -408,12 +433,19 @@ build_join_rel(PlannerInfo *root, /* * Set up foreign-join fields if outer and inner relation are foreign - * tables (or joins) belonging to the same server. + * tables (or joins) belonging to the same server and using the same + * user mapping. + * + * Otherwise those fields are left invalid, so FDW API will not be called + * for the join relation. */ if (OidIsValid(outer_rel->serverid) && - inner_rel->serverid == outer_rel->serverid) + inner_rel->serverid == outer_rel->serverid && + inner_rel->umid == outer_rel->umid) { + Assert(OidIsValid(outer_rel->umid)); joinrel->serverid = outer_rel->serverid; + joinrel->umid = outer_rel->umid; joinrel->fdwroutine = outer_rel->fdwroutine; } |