summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-01-26Be more clear when a new column name collides with a system column name.Robert Haas
We now use the same error message for ALTER TABLE .. ADD COLUMN or ALTER TABLE .. RENAME COLUMN that we do for CREATE TABLE. The old message was accurate, but might be confusing to users not aware of our system columns. Vik Reykja, with some changes by me, and further proofreading by Tom Lane
2012-01-26Make bgwriter sleep longer when it has no work to do, to save electricity.Heikki Linnakangas
To make it wake up promptly when activity starts again, backends nudge it by setting a latch in MarkBufferDirty(). The latch is kept set while bgwriter is active, so there is very little overhead from that when the system is busy. It is only armed before going into longer sleep. Peter Geoghegan, with some changes by me.
2012-01-26Add missing #include, to suppress compiler warning.Robert Haas
2012-01-26Fix a copy/pasted typo in several commentsMagnus Hagander
2012-01-26Add deadlock counter to pg_stat_databaseMagnus Hagander
Adds a counter that tracks number of deadlocks that occurred in each database to pg_stat_database. Magnus Hagander, reviewed by Jaime Casanova
2012-01-26Classify DROP operations by whether or not they are user-initiated.Robert Haas
This doesn't do anything useful just yet, but is intended as supporting infrastructure for allowing sepgsql to sensibly check DROP permissions. KaiGai Kohei and Robert Haas
2012-01-26Track temporary file count and size in pg_stat_databaseMagnus Hagander
Add counters for number and size of temporary files used for spill-to-disk queries for each database to the pg_stat_database view. Tomas Vondra, review by Magnus Hagander
2012-01-26Damage control for yesterday's CheckIndexCompatible changes.Robert Haas
Rip out a regression test that doesn't play well with settings put in place by the build farm, and rewrite the code in CheckIndexCompatible in a hopefully more transparent style.
2012-01-25Instrument index-only scans to count heap fetches performed.Robert Haas
Patch by me; review by Tom Lane, Jeff Davis, and Peter Geoghegan.
2012-01-25Have \copy go through SendQueryAlvaro Herrera
This enables a bunch of features, notably ON_ERROR_ROLLBACK. It also makes COPY failure (either in the server or psql) as a whole behave more sanely in psql. Additionally, having more commands in the same command line as COPY works better (though since psql splits lines at semicolons, this doesn't matter much unless you're using -c). Also tighten a couple of switches on PQresultStatus() to add PGRES_COPY_BOTH support and stop assuming that unknown statuses received are errors; have those print diagnostics where warranted. Author: Noah Misch
2012-01-25Make CheckIndexCompatible simpler and more bullet-proof.Robert Haas
This gives up the "don't rewrite the index" behavior in a couple of relatively unimportant cases, such as changing between an array type and an unconstrained domain over that array type, in return for making this code more future-proof. Noah Misch
2012-01-25Allow pg_basebackup from standby node with safety checking.Simon Riggs
Base backup follows recommended procedure, plus goes to great lengths to ensure that partial page writes are avoided. Jun Ishizuka and Fujii Masao, with minor modifications
2012-01-25Add pg_trigger_depth() functionAlvaro Herrera
This reports the depth level of triggers currently in execution, or zero if not called from inside a trigger. No catversion bump in this patch, but you have to initdb if you want access to the new function. Author: Kevin Grittner
2012-01-24Add new replication mode synchronous_commit = 'write'.Simon Riggs
Replication occurs only to memory on standby, not to disk, so provides additional performance if user wishes to reduce durability level slightly. Adds concept of multiple independent sync rep queues. Fujii Masao and Simon Riggs
2012-01-24Remove quotes around format_type_be() outputPeter Eisentraut
format_type_be() takes care of any needed quoting itself.
2012-01-24Suppress variable-clobbered-by-longjmp warning seen with older gcc versions.Tom Lane
2012-01-24Suppress possibly-uninitialized-variable warning seen with older gcc versions.Tom Lane
2012-01-24Reduce tab outdent of "error handling" GUC comments in postgresql.conf,Bruce Momjian
to match surrounding outdenting.
2012-01-24Adjustments to regression tests for security_barrier views.Robert Haas
Drop the role we create, so regression tests pass even when run more than once against the same cluster, a problem noted by Tom Lane and Jeff Janes. Also, rename the temporary role so that it starts with "regress_", to make it unlikely that we'll collide with an existing role name while running "make installcheck", per further gripe from Tom Lane.
2012-01-23Resolve timing issue with logging locks for Hot Standby.Simon Riggs
We log AccessExclusiveLocks for replay onto standby nodes, but because of timing issues on ProcArray it is possible to log a lock that is still held by a just committed transaction that is very soon to be removed. To avoid any timing issue we avoid applying locks made by transactions with InvalidXid. Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee
2012-01-23ALTER <thing> [IF EXISTS] ... allows silent DDL if required,Simon Riggs
e.g. ALTER FOREIGN TABLE IF EXISTS foo RENAME TO bar Pavel Stehule
2012-01-21psql: Add support for tab completion of GRANT/REVOKE rolePeter Eisentraut
Previously, only GRANT/REVOKE privilege was supported. reviewed by Pavel Stehule
2012-01-20Check number of fields in IDENTIFY_SYSTEM responseMagnus Hagander
Jaime Casanova
2012-01-20Further doc cleanups from the pg_stat_activity changesMagnus Hagander
Fujii Masao
2012-01-19Add bitwise AND, OR, and NOT operators for macaddr data type.Robert Haas
Brendan Jurd, reviewed by Fujii Masao
2012-01-19Separate state from query string in pg_stat_activityMagnus Hagander
This separates the state (running/idle/idleintransaction etc) into it's own field ("state"), and leaves the query field containing just query text. The query text will now mean "current query" when a query is running and "last query" in other states. Accordingly,the field has been renamed from current_query to query. Since backwards compatibility was broken anyway to make that, the procpid field has also been renamed to pid - along with the same field in pg_stat_replication for consistency. Scott Mead and Magnus Hagander, review work from Greg Smith
2012-01-19Make pg_relation_size() and friends return NULL if the object doesn't exist.Heikki Linnakangas
That avoids errors when the functions are used in queries like "SELECT pg_relation_size(oid) FROM pg_class", and a table is dropped concurrently. Phil Sorber
2012-01-18Fix corner case in cleanup of transactions using SSI.Heikki Linnakangas
When the only remaining active transactions are READ ONLY, we do a "partial cleanup" of committed transactions because certain types of conflicts aren't possible anymore. For committed r/w transactions, we release the SIREAD locks but keep the SERIALIZABLEXACT. However, for committed r/o transactions, we can go further and release the SERIALIZABLEXACT too. The problem was with the latter case: we were returning the SERIALIZABLEXACT to the free list without removing it from the finished list. The only real change in the patch is the SHMQueueDelete line, but I also reworked some of the surrounding code to make it obvious that r/o and r/w transactions are handled differently -- the existing code felt a bit too clever. Dan Ports
2012-01-18Show psql timing output for failed queries as well as successful onesMagnus Hagander
This is useful for example when a long-runing statement such as CREATE INDEX fails after a long time.
2012-01-18Fix warning about unused variableMagnus Hagander
2012-01-17Regression tests for security_barrier views.Robert Haas
KaiGai Kohei
2012-01-17Catch fatal flex errors in the GUC file lexer.Robert Haas
This prevents the postmaster from unexpectedly croaking if postgresql.conf contains something like: include 'invalid_directory_name' Noah Misch. Reviewed by Tom Lane and myself.
2012-01-16fastgetattr is in access/htup.h, not access/heapam.hRobert Haas
Noted by Peter Geoghegan
2012-01-16Disallow merging ONLY constraints in children tablesAlvaro Herrera
When creating a child table, or when attaching an existing table as child of another, we must not allow inheritable constraints to be merged with non-inheritable ones, because then grandchildren would not properly get the constraint. This would violate the grandparent's expectations. Bugs noted by Robert Haas. Author: Nikhil Sontakke
2012-01-16psql: Fix memory leakPeter Eisentraut
The command \password username leaked memory.
2012-01-16Prevent adding relations to a concurrently dropped schema.Robert Haas
In the previous coding, it was possible for a relation to be created via CREATE TABLE, CREATE VIEW, CREATE SEQUENCE, CREATE FOREIGN TABLE, etc. in a schema while that schema was meanwhile being concurrently dropped. This led to a pg_class entry with an invalid relnamespace value. The same problem could occur if a relation was moved using ALTER .. SET SCHEMA while the target schema was being concurrently dropped. This patch prevents both of those scenarios by locking the schema to which the relation is being added using AccessShareLock, which conflicts with the AccessExclusiveLock taken by DROP. As a desirable side effect, this also prevents the use of CREATE OR REPLACE VIEW to queue for an AccessExclusiveLock on a relation on which you have no rights: that will now fail immediately with a permissions error, before trying to obtain a lock. We need similar protection for all other object types, but as everything other than relations uses a slightly different set of code paths, I'm leaving that for a separate commit. Original complaint (as far as I could find) about CREATE by Nikhil Sontakke; risk for ALTER .. SET SCHEMA pointed out by Tom Lane; further details by Dan Farina; patch by me; review by Hitoshi Harada.
2012-01-15Improve efficiency of recent changes to plperl's sv2cstr().Andrew Dunstan
Along the way, add a missing dependency in the GNUmakefile. Alex Hunsaker, with a slight adjustment by me.
2012-01-15Fix poll() implementation of WaitLatchOrSocket to notice postmaster death.Heikki Linnakangas
When the remote end of the pipe is closed, select() reports the fd as readable, but poll() has a separate POLLHUP return code for that. Spotted by Peter Geoghegan.
2012-01-15Allow a user to kill his own queries using pg_cancel_backend()Magnus Hagander
Allows a user to use pg_cancel_queries() to cancel queries in other backends if they are running under the same role. pg_terminate_backend() still requires superuser permissoins. Short patch, many authors working on the bikeshed: Magnus Hagander, Josh Kupershmidt, Edward Muller, Greg Smith.
2012-01-14Detect invalid permutations in isolationtesterAlvaro Herrera
isolationtester is now able to continue running other permutations when it detects that one of them is invalid, which is useful during initial development of spec files. Author: Alexander Shulgin
2012-01-14Avoid NULL pointer dereference in isolationtesterAlvaro Herrera
2012-01-14Make superuser imply replication privilege. The idea of a privilege thatHeikki Linnakangas
superuser doesn't have doesn't make much sense, as a superuser can do whatever he wants through other means, anyway. So instead of granting replication privilege to superusers in CREATE USER time by default, allow replication connection from superusers whether or not they have the replication privilege. Patch by Noah Misch, per discussion on bug report #6264
2012-01-14initdb: Remove support for crypt authentication methodPeter Eisentraut
This was removed from the backend a long time ago, but initdb still thought that it was OK to use in the -A option.
2012-01-13Fix broken logic in lazy_vacuum_heap.Robert Haas
As noted by Tom Lane, the previous coding in this area, which I introduced in commit bbb6e559c4ea0fb4c346beda76736451dc24eb4e, was poorly tested and caused the vacuum's second heap to go into what would have been an infinite loop but for the fact that it eventually caused a memory allocation failure. This version seems to work better.
2012-01-13Typo fix.Robert Haas
2012-01-13Correctly initialise shared recoveryLastRecPtr in recovery.Simon Riggs
Previously we used ReadRecPtr rather than EndRecPtr, which was not a serious error but caused pg_stat_replication to report incorrect replay_location until at least one WAL record is replayed. Fujii Masao
2012-01-13Minor but necessary improvements to WAL keepalivesSimon Riggs
Fujii Masao
2012-01-12Fix CLUSTER/VACUUM FULL for toast values owned by recently-updated rows.Tom Lane
In commit 7b0d0e9356963d5c3e4d329a917f5fbb82a2ef05, I made CLUSTER and VACUUM FULL try to preserve toast value OIDs from the original toast table to the new one. However, if we have to copy both live and recently-dead versions of a row that has a toasted column, those versions may well reference the same toast value with the same OID. The patch then led to duplicate-key failures as we tried to insert the toast value twice with the same OID. (The previous behavior was not very desirable either, since it would have silently inserted the same value twice with different OIDs. That wastes space, but what's worse is that the toast values inserted for already-dead heap rows would not be reclaimed by subsequent ordinary VACUUMs, since they go into the new toast table marked live not deleted.) To fix, check if the copied OID already exists in the new toast table, and if so, assume that it stores the desired value. This is reasonably safe since the only case where we will copy an OID from a previous toast pointer is when toast_insert_or_update was given that toast pointer and so we just pulled the data from the old table; if we got two different values that way then we have big problems anyway. We do have to assume that no other backend is inserting items into the new toast table concurrently, but that's surely safe for CLUSTER and VACUUM FULL. Per bug #6393 from Maxim Boguk. Back-patch to 9.0, same as the previous patch.
2012-01-12Tweak duplicate-index-column regression test to avoid locale sensitivity.Tom Lane
The originally-chosen test case gives different results in es_EC locale because of unusual rule for sorting strings beginning with "LL". Adjust the comparison value to avoid that, while hopefully not introducing new locale dependencies elsewhere. Per report from Jaime Casanova.
2012-01-11Validate number of steps specified in permutationAlvaro Herrera
A permutation that specifies more steps than defined causes isolationtester to crash, so avoid that. Using less steps than defined should probably not be a problem, but no spec currently does that.
generated by cgit v1.2.3 (git 2.46.0) at 2025-08-22 09:34:56 +0000