summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2009-03-12Fix core dump due to null-pointer dereference in to_char() when datetimeTom Lane
format codes are misapplied to a numeric argument. (The code still produces a pretty bogus error message in such cases, but I'll settle for stopping the crash for now.) Per bug #4700 from Sergey Burladyan. Problem exists in all supported branches, so patch all the way back. In HEAD, also clean up some ugly coding in the nearby cache management code.
2009-03-11Code review for dtrace probes added (so far) to 8.4. Adjust placement ofTom Lane
some bufmgr probes, take out redundant and memory-leak-inducing path arguments to smgr__md__read__done and smgr__md__write__done, fix bogus attempt to recalculate space used in sort__done, clean up formatting in places where I'm not sure pgindent will do a nice job by itself.
2009-03-11Some languages have symbols with zero display's width or/and vowels/signs whichTeodor Sigaev
are not an alphabetic character although they are not word-breakers too. So, treat them as part of word. Per off-list discussion with Dibyendra Hyoju <dibyendra@gmail.com> and and Bal Krishna Bal <balkrishna7bal@gmail.com> about Nepali language and Devanagari alphabet.
2009-03-11Use thread-local storage for querybuffer in fmtId() on Windows, when needed ↵Andrew Dunstan
(i.e. when running pg_restore, which might run in parallel). Only reopen archive file when we really need to read from it, in parallel code. Otherwise, close it immediately in a worker, if possible.
2009-03-11Improve match_special_index_operator() to recognize that LIKE with anTom Lane
exact-match pattern (no wildcard) can be index-optimized in some cases where a prefix-match pattern cannot; specifically, since the required index clause is simple equality, it works for regular text/varchar indexes even when the locale is not C. I'm not sure how often this case really comes up, but since it requires hardly any additional work to handle it, we might as well get it right. Motivated by a discussion on the JDBC list.
2009-03-10Make SubPlan nodes carry the result's typmod as well as datatype OID. This isTom Lane
for consistency with the (relatively) recent addition of typmod to SubLink. An example of why it's a good idea is to be seen in the recent "failed to locate grouping columns" bug, which wouldn't have happened if a SubPlan exposed the same typmod info as the SubLink it was derived from. This could be back-patched, since it doesn't affect any on-disk data format, but for the moment it doesn't seem necessary to do so.
2009-03-10Fix set_subquery_pathlist() to copy the RTE's subquery before it gets mangledTom Lane
by the planning process. This prevents the "failed to locate grouping columns" error recently reported by Dickson Guedes. That happens because planning replaces SubLinks by SubPlans in the subquery's targetlist, and exprTypmod() is smarter about the former than the latter, causing the apparent type of the subquery's output columns to change. This seems to be a deficiency we should fix in exprTypmod(), but that will be a much more invasive patch with possible side-effects elsewhere, so I'll do that only in HEAD. Back-patch to 8.3. Arguably the lack of a copying step is broken/dangerous all the way back, but in the absence of known problems I'll refrain from making the older branches pay the extra cost. (The reason this particular symptom didn't appear before is that exprTypmod() wasn't smart about SubLinks either, until 8.3.)
2009-03-10Prevent recursion during parse of email-like string with multiple '@'.Teodor Sigaev
Patch by Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
2009-03-09In parse_bool_with_len, avoid crash when no result pointer is passed. ProbablyPeter Eisentraut
an unlikely call mode, but better be safe.
2009-03-09Tweak the regression test case so that the ordering of numbers vs. lettersPeter Eisentraut
doesn't matter. This fixes failures in the Czech locale.
2009-03-09Accept 'on' and 'off' as input for boolean data type, unifying the syntaxPeter Eisentraut
that the data type and GUC accepts. ITAGAKI Takahiro
2009-03-09Add summarization comment about visibility functions.Bruce Momjian
Add URL about the Halloween problem.
2009-03-09Revert pg_bind_textdomain_codeset to a existant-but-empty function whenAlvaro Herrera
ENABLE_NLS is not defined, for better compatibility of the backend with modules compiled the other way. Per note from Tom after my previous commit.
2009-03-08Fix MSVC build for new ways to pull in keywords.c and kwlookup.c.Magnus Hagander
2009-03-08pg_bind_textdomain_codeset must exist only on ENABLE_NLS.Alvaro Herrera
2009-03-08Add comments about kwlookup.c expectationsAlvaro Herrera
2009-03-08On Windows, call bind_textdomain_codeset on domains other than the default one,Alvaro Herrera
too, so that the codeset is properly mapped on the newly added PL domains.
2009-03-07Make pg_hba parsing report all errors in the file before aborting the load,Magnus Hagander
instead of just reporting the first one. Selena Deckelmann
2009-03-07Avoid MSVC breakage caused by my previous commit by not using a variable inAlvaro Herrera
the src/bin/scripts Makefile.
2009-03-07Separate the key word list that lived in keywords.c into a new header fileAlvaro Herrera
kwlist.h, to avoid having to link the backend object file into other programs like pg_dump. We can now simply symlink a single source file from the backend (kwlookup.c, containing the shared routine ScanKeywordLookup) and compile it locally, which is a lot cleaner.
2009-03-05Teach the planner to support index access methods that only implementTom Lane
amgettuple or only implement amgetbitmap, instead of the former assumption that every AM supports both APIs. Extracted with minor editorialization from Teodor's fast-GIN-insert patch; whatever becomes of that, this seems like a simple and reasonable generalization of the index AM interface spec.
2009-03-05Fix column privilege checking for cases where parent and child have differentTom Lane
attribute numbering. Also, a parent whole-row reference should not require select privilege on child columns that aren't inherited from the parent. Problem diagnosed by KaiGai Kohei, though this isn't exactly his patch.
2009-03-05Message tuningPeter Eisentraut
2009-03-05Add MUST (Mauritius Island Summer Time) to the list of known abbreviations.Heikki Linnakangas
Mauritius began using DST in the summer 2008-2009; the Olson library has been updated already. Xavier Bugaud
2009-03-04Put back our old workaround for machines that declare cbrt() in math.h butTom Lane
fail to provide the function itself. Not sure how we escaped testing anything later than 7.3 on such cases, but they still exist, as per André Volpato's report about AIX 5.3.
2009-03-04Change hba load failure message to LOG instead of WARNING.Magnus Hagander
Per comment from Tom.
2009-03-04Reload config file in startup process on SIGHUP.Heikki Linnakangas
Fujii Masao
2009-03-04Clarify to the translator that yyerror() deals with the translation ofPeter Eisentraut
"syntax error", not the literal string. I was previously confused on this matter, but I have now verified that everything is translated properly.
2009-03-04Provide some proper minimal documentation for the pg_dump(all) --binary-upgradePeter Eisentraut
option. We don't want to commit to what it does, but hiding it will only cause confusion.
2009-03-04Add some sanity checks to CREATE CAST ... WITHOUT FUNCTION. DisallowHeikki Linnakangas
composite, enum and array types, as those are surely not binary-compatible with anything else because of the embedded OIDs. Inspired by bug report by Oleg Serov.
2009-03-04Add new SQL:2008 error codes for invalid LIMIT and OFFSET values. RemovePeter Eisentraut
unused nonstandard error code that was perhaps intended for this but never used.
2009-03-04Don't actively violate the system limit of maximum open files (RLIMIT_NOFILE).Peter Eisentraut
This avoids irritating kernel logs (if system overstep violations are enabled) and also the grsecurity alert when starting PostgreSQL. original patch by Jacek Drobiecki References: http://archives.postgresql.org/pgsql-bugs/2004-05/msg00103.php http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=248967
2009-03-04Log a warning instead of shutting down the system if we can't loadMagnus Hagander
pg_hba.conf on reload (for example due to a permission error). Selena Deckelmann
2009-03-03Fix copy-pasto in the patch to allow background writer to run duringHeikki Linnakangas
recovery: if background writer or pgstat process dies during recovery (or any other child process, but those two are the only ones running), send SIGQUIT to the startup process using correct pid.
2009-03-03Remove the placeholder LWLockId in place of the removed FreeSpaceLock.Heikki Linnakangas
As pointed out by ITAGAKI Takahiro, we split SInvalLock into two in 8.4, so to keep the numbers of the rest of the locks unchanged from 8.3, we don't need a placeholder.
2009-03-02When we are in error recursion trouble, arrange to suppress translation andTom Lane
encoding conversion of any elog/ereport message being sent to the frontend. This generalizes a patch that I put in last October, which suppressed translation of only specific messages known to be associated with recursive can't-translate-the-message behavior. As shown in bug #4680, we need a more general answer in order to have some hope of coping with broken encoding conversion setups. This approach seems a good deal less klugy anyway. Patch in all supported branches.
2009-03-02Fix usage of char2wchar/wchar2char. Changes:Teodor Sigaev
- pg_wchar and wchar_t could have different size, so char2wchar doesn't call pg_mb2wchar_with_len to prevent out-of-bound memory bug - make char2wchar/wchar2char symmetric, now they should not be called with C-locale because mbstowcs/wcstombs oftenly doesn't work correct with C-locale. - Text parser uses pg_mb2wchar_with_len directly in case of C-locale and multibyte encoding Per bug report by Hiroshi Inoue <inoue@tpf.co.jp> and following discussion. Backpatch up to 8.2 when multybyte support was implemented in tsearch.
2009-02-28Fix buffer allocations in encoding conversion routines so that they won'tTom Lane
fail on zero-length inputs. This isn't an issue in normal use because the conversion infrastructure skips calling the converters for empty strings. However a problem was created by yesterday's patch to check whether the right conversion function is supplied in CREATE CONVERSION. The most future-proof fix seems to be to make the converters safe for this corner case.
2009-02-28Shave a few cycles in compare_pathkeys() by checking for pointer-identicalTom Lane
input lists before we grovel through the lists. This doesn't save much, but testing shows that the case of both inputs NIL is common enough that it saves something. And this is used enough to be a hotspot.
2009-02-28Reduce the maximum value of vacuum_cost_delay and autovacuum_vacuum_cost_delayTom Lane
to 100ms (from 1000). This still seems to be comfortably larger than the useful range of the parameter, and it should help discourage people from picking uselessly large values. Tweak the documentation to recommend small values, too. Per discussion of a couple weeks ago.
2009-02-27Temporarily (I hope) disable flattening of IN/EXISTS sublinks that are withinTom Lane
the ON clause of an outer join. Doing so is semantically correct but results in de-optimizing queries that were structured to take advantage of the sublink style of execution, as seen in recent complaint from Kevin Grittner. Since the user can get the other behavior by reorganizing his query, having the flattening happen automatically is just a convenience, and that doesn't justify breaking existing applications. Eventually it would be nice to re-enable this, but that seems to require a significantly different approach to outer joins in the executor.
2009-02-27Tighten up join ordering rules to account for recent more-careful analysisTom Lane
of the associativity of antijoins. Also improve optimizer/README discussion of outer join ordering rules.
2009-02-27In CREATE CONVERSION, test that the given function is a valid conversionHeikki Linnakangas
function for the specified source and destination encodings. We do that by calling the function with an empty string. If it can't perform the requested conversion, it will throw an error. Backport to 7.4 - 8.3. Per bug report #4680 by Denis Afonin.
2009-02-27Add the long options to the psql --help display, where they were curiouslyPeter Eisentraut
missing. Since this touches most lines of the help output, also change the mix of puts and printf calls to printf everywhere, for easier code editing and reviewing.
2009-02-27Improve create_unique_path to not be fooled by unrelated clauses that happenTom Lane
to be syntactically part of a semijoin clause. For example given WHERE EXISTS(SELECT ... WHERE upper.var = lower.var AND some-condition) where some-condition is just a restriction on the lower relation, we can use unique-ification on lower.var after having applied some-condition within the scan on lower.
2009-02-26Remove outdated join_1.out regression test comparison file. This hasTom Lane
been broken for more than a month, so evidently it's not needed, at least not for any configuration in the buildfarm. We can correct it and replace it later if we find something that still needs it.
2009-02-26Final removal of -q options, which haven't done anything since 8.3 andPeter Eisentraut
were marked for removal in 8.4.
2009-02-26Add a -w/--no-password option that prevents all password prompts to allPeter Eisentraut
programs that have a -W/--password option. In passing, remove the ancient PSQL_ALWAYS_GET_PASSWORDS compile option.
2009-02-25Fix an old problem in decompilation of CASE constructs: the ruleutils.c codeTom Lane
looks for a CaseTestExpr to figure out what the parser did, but it failed to consider the possibility that an implicit coercion might be inserted above the CaseTestExpr. This could result in an Assert failure in some cases (but correct results if Asserts weren't enabled), or an "unexpected CASE WHEN clause" error in other cases. Per report from Alan Li. Back-patch to 8.1; problem doesn't exist before that because CASE was implemented differently.
2009-02-25Remove references to foreign data wrapper libraries, since they haveMagnus Hagander
been removed. This should unbreak the msvc build again.