summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2003-04-04Code review for pg_stat_get_backend_activity_start patch --- fixTom Lane
return type, make protection condition agree with recent change to pg_stat_get_backend_activity, clean up documentation.
2003-04-03Remove zero_damaged_pages from postgresql.conf.sample; the only way toTom Lane
find out about it is to read the documentation that tells you how dangerous it is. Add default_transaction_read_only to documentation; seems to have been overlooked in patch that added read-only transactions. Clean up check_guc comparison script, which has been suffering bit rot.
2003-04-03Prevent EXPLAIN (without ANALYZE) SELECT ... INTO from creating an INTOTom Lane
table. Needed due to recent change that makes us call ExecutorStart even when not planning to carry out the query.
2003-04-03Don't re-invent the strchr() wheel.Tom Lane
2003-04-03Fix load_user/load_group to not leave dangling pointers around if theTom Lane
config files are present on one pass and not present on a later pass.
2003-04-03const-ify functions used with completion_matches(), to suppressTom Lane
cast-away-const warnings from compilers pickier than gcc.
2003-04-03Repair incorrect checking of grouped/ungrouped variables in the presenceTom Lane
of unnamed joins; per pghackers discussion 31-Mar-03.
2003-04-03Add prototype for toupper/tolower().Bruce Momjian
2003-04-02Fix buffer overrun in to_ascii(), per report from Guido Notari.Tom Lane
2003-04-02Fix convSockAddr6to4(): eliminate bogus assumptions about byte ordering,Tom Lane
remove useless SockAddr_ntop() call. Per report from Andreas Pflug.
2003-04-02Fix platform-dependent failure introduced by recent to_char changesTom Lane
(ye good olde uninitialized-local-variable).
2003-04-02This is a derived file and should never have been added to CVS.Tom Lane
2003-04-02Whack getaddrinfo() patch around until it works, more or less, onTom Lane
machines without IPv6. Or at least it works on HPUX 10.20 ...
2003-04-01Add missing semicolon.Tom Lane
2003-04-01More patches for informix compatibility.Michael Meskes
2003-03-31Skip START WITH in sequence definition when it's the default value --Bruce Momjian
and hasn't been called yet. Fixes bug where it wasn't supplied (due to being NULL). Rod Taylor
2003-03-31The following patch cleans up the deferred trigger mechanism. There isBruce Momjian
an unneeded memory context and some variables that are not used anymore. It's pretty trivial and the regression tests pass fine. There's no change in functionality, only deletion of unused code. I left an empty function because maybe I'll need it for nested transactions. Alvaro Herrera
2003-03-31TestConfiguration returns int, not bool. This mistake is relativelyTom Lane
harmless on signed-char machines but would lead to core dump in the deadlock detection code if char is unsigned. Amazingly, this bug has been here since 7.1 and yet wasn't reported till now. Thanks to Robert Bruccoleri for providing the opportunity to track it down.
2003-03-30Properly document default value of log_min_error_statement in postgresql.conf.Bruce Momjian
2003-03-30Forgot two new files and one that was moved.Michael Meskes
2003-03-30Moved Informix stuff to its own compat library. Interval datetype is now ↵Michael Meskes
fully functional.
2003-03-29Simplify the socket handling code by supplying a replacement getaddrinfo()Peter Eisentraut
function if the OS doesn't provide one.
2003-03-29[ Backpatch to 7.3.X.]Bruce Momjian
SSL_read/write can error needing ERROR_WANT_READ or ERROR_WANT_WRITE.
2003-03-29[ Backpatch to 7.3.X.]Bruce Momjian
typing error in src/backend/libpq/be-secure.c ??? Long Description In src/backend/libpq/be-secure.c: secure_write on SSL_ERROR_WANT_WRITE call secure_read instead secure_write again. May be is this a typing error? Sergey N. Yatskevich (syatskevich@n21lab.gosniias.msk.ru)
2003-03-28Add code to apply some simple sanity checks to the header fields of aTom Lane
page when it's read in, per pghackers discussion around 17-Feb. Add a GUC variable zero_damaged_pages that causes the response to be a WARNING followed by zeroing the page, rather than the normal ERROR; this is per Hiroshi's suggestion that there needs to be a way to get at the data in the rest of the table.
2003-03-28Fix NULL casting warning, pointed out by Joe ConwayBruce Momjian
2003-03-27Fix bogus coding of SET DEFAULT ri triggers ... or at least make it lessTom Lane
bogus than it was. Per bug report from Adrian Pop.
2003-03-27Add <stdlib> to add calloc() prototype.Bruce Momjian
2003-03-27Fix syntax error in to_char fixes --- was defining variable in main codeBruce Momjian
block, ala C++.
2003-03-27It may not be obvious to you, but the plpython regression testsBruce Momjian
include output that vary depending on the python build one is running. Basically, the order of keys in a dictionary is non-deterministic, and that part of the test fails for me regularly. I rewrote the test to work around this problem, and include a patch file with that change and the change to the expected otuput as well. Mike Meyer
2003-03-27New \d format:Bruce Momjian
Example: test=# \d test Table "public.test" Column | Type | Modifiers --------+---------+----------- a | integer | not null Indexes: "test_pkey" PRIMARY KEY btree (a) Check Constraints: "$2" CHECK (a > 1) Foreign Key Constraints: "$1" FOREIGN KEY (a) REFERENCES parent(b) Rules: myrule AS ON INSERT TO test DO INSTEAD NOTHING Triggers: "asdf asdf" AFTER INSERT OR DELETE ON test FOR EACH STATEMENT EXECUTE PROCEDURE update_pg_pwd_and_pg_group(), mytrigger AFTER INSERT OR DELETE ON test FOR EACH ROW EXECUTE PROCEDURE update_pg_pwd_and_pg_group() I have minimised the double quoting of identifiers as much as I could easily, and I will submit another patch when I have time to work on it that will use a 'fmtId' function to determine it exactly. I think it's a significant improvement in legibility... Obviously the table example above is slightly degenerate in that not many tables in production have heaps of (non-constraint) triggers and rules. Christopher Kings-Lynne
2003-03-27Add new file.Bruce Momjian
2003-03-27Add new files.Bruce Momjian
2003-03-27This patch implements holdable cursors, following the proposalBruce Momjian
(materialization into a tuple store) discussed on pgsql-hackers earlier. I've updated the documentation and the regression tests. Notes on the implementation: - I needed to change the tuple store API slightly -- it assumes that it won't be used to hold data across transaction boundaries, so the temp files that it uses for on-disk storage are automatically reclaimed at end-of-transaction. I added a flag to tuplestore_begin_heap() to control this behavior. Is changing the tuple store API in this fashion OK? - in order to store executor results in a tuple store, I added a new CommandDest. This works well for the most part, with one exception: the current DestFunction API doesn't provide enough information to allow the Executor to store results into an arbitrary tuple store (where the particular tuple store to use is chosen by the call site of ExecutorRun). To workaround this, I've temporarily hacked up a solution that works, but is not ideal: since the receiveTuple DestFunction is passed the portal name, we can use that to lookup the Portal data structure for the cursor and then use that to get at the tuple store the Portal is using. This unnecessarily ties the Portal code with the tupleReceiver code, but it works... The proper fix for this is probably to change the DestFunction API -- Tom suggested passing the full QueryDesc to the receiveTuple function. In that case, callers of ExecutorRun could "subclass" QueryDesc to add any additional fields that their particular CommandDest needed to get access to. This approach would work, but I'd like to think about it for a little bit longer before deciding which route to go. In the mean time, the code works fine, so I don't think a fix is urgent. - (semi-related) I added a NO SCROLL keyword to DECLARE CURSOR, and adjusted the behavior of SCROLL in accordance with the discussion on -hackers. - (unrelated) Cleaned up some SGML markup in sql.sgml, copy.sgml Neil Conway
2003-03-27Attached are two patches for psql's tab-completion.c.Bruce Momjian
The first cleans up a couple of minor errors and ommissions and adds tab completion support to more slash commands, e.g. \dv. The second is an attempt to add tab completion for schemas and fully qualified relation names (e.g. public.mytable ). I think this covers the TODO-item: "Allow psql to do table completion for SELECT * FROM schema_part and table completion for SELECT * FROM schema_name." This happens via union selects querying: - relation_name in current search path; - schema_name; - schema.relation_name matching the current input string. E.g: SELECT p[TAB] will produce a list of all appropriate relation names in the current search path which begin with 'p', and also all schema names which begin with 'p'; \d pub[TAB] will produce any relation names in the current search path and also any schema names beginning with 'pub'; \d public.[TAB] will produce a list of all relations in the schema 'public'; \d public.my[TAB] produces all relation names beginning with 'my' in schema 'public'. It seems to work for me; comments, suggestions, particularly regarding the coding and queries, are very welcome. Note that tables, indexes, views and sequences relations in the 'pg_catalog' namespace are excluded even though they are in the current search path. I found not doing this produced annoying behaviour when expanding names beginning with 'p'. People who work with system tables a lot may not like this though; I can look for another solution if necessary. Ian Barwick
2003-03-27AddsBruce Momjian
ALTER TABLE foo CLUSTER ON bar; In pg_dumps, to preserve cluster settings. Christopher Kings-Lynne
2003-03-27Reorder language creation to restore constistently.Bruce Momjian
Laurent FAILLIE
2003-03-27to_char fixes, Karel ZakBruce Momjian
2003-03-27GetTupleForTrigger must use outer transaction's command counter for timeTom Lane
qual checking, not GetCurrentCommandId. Per test case from Steve Wolfe.
2003-03-27More changes to pgtypeslib and set optimization to -O1.Michael Meskes
2003-03-25Merge documentation into one book. (Build with "make html".) ReplacePeter Eisentraut
vague cross-references with real links.
2003-03-25plpgsql can assign to subscripted variables now, e.g.Tom Lane
x[42] := whatever; The facility is pretty primitive because it doesn't do array slicing and it has the same semantics as array update in SQL (array must already be non-null, etc). But it's a start.
2003-03-25patch to notify listeners on error from Csaba NagyDave Cramer
2003-03-25Use PQfreemem() consistently, and document its use for Notify.Bruce Momjian
Keep PQfreeNotify() around for binary compatibility.
2003-03-25added DISTINCT to the query to get cross reference. This is required when ↵Dave Cramer
two columns in a table are both foreign keys to another table. From Peter Royal proyal@pace2020.com
2003-03-25fixed problem where information from previous updates was leaking into ↵Dave Cramer
subsequent updates patch from Shawn Green, slightly modified
2003-03-25Factor out duplicate code for computing values of PLpgSQL_datum items.Tom Lane
This is to help localize the changes needed for adding a new kind of PLpgSQL_datum (like, say, an array element...)
2003-03-24Ignore SIGXFSZ (if platform has it), so that ulimit violations work likeTom Lane
disk-full conditions instead of provoking a backend crash. Per suggestion from Frederic Surleau.
2003-03-24Modify keys_are_unique optimization to release buffer pins before itTom Lane
returns NULL. This avoids out-of-buffers failures during many-way indexscans, as in Shraibman's complaint of 21-Mar.
2003-03-24Add comment to postgresql.conf:Bruce Momjian
#search_path = '$user,public' # schema names