| Age | Commit message (Collapse) | Author |
|---|
|
Per gripes from Mike Mascari and Bernd Heller.
|
|
that return tuples (such as EXPLAIN). Per gripe from Michael Fuhr.
Side effect: fix an old bug that unintentionally disabled backward scans
for all SPI-created cursors.
|
|
|
|
Yutaka <tanida@sra.co.jp>.
|
|
column with a default expression. In that situation, we need to rewrite
the heap relation. To evaluate the new default expression, we use
ExecEvalExpr(); however, this can allocate memory in the current memory
context, and ATRewriteTable() does not switch out of the active portal's
heap memory context. The end result is a rather large memory leak (on
the order of gigabytes for a reasonably sized table).
This patch changes ATRewriteTable() to switch to the per-tuple memory
context before beginning the per-tuple loop. It also removes an explicit
heap_freetuple() in the loop, since that is no longer needed.
In an unrelated change, I noticed the code was scanning through the
attributes of the new tuple descriptor for each tuple of the old table.
I changed this to use precomputation, which should slightly speed up
the loop.
Thanks to steve@deefs.net for reporting the leak.
|
|
|
|
there are corner cases involving dropping toasted columns in which the
previous coding would fail, too: the new version of the table might not
have any TOAST table, but we'd still propagate possibly-wide values of
dropped columns forward.
|
|
now depends on.
|
|
ReleaseAndReadBuffer during GIST index searches. We already did this
in btree and rtree, might as well do it here too.
|
|
from LockRelease() and LockReleaseAll() into it. From Heikki Linnakangas.
|
|
database: aggregates should be dumped in the same pass as operators,
not in the same pass as functions.
|
|
This refactoring does not change any algorithms or data structures, just
remove visibility of the ARC datastructures from other source files.
|
|
two arguments. Per suggestions from A. Ogawa.
|
|
form of CASE (eg, CASE 0 WHEN 1 THEN ...) can be constant-folded as it
was in 7.4. Also, avoid constant-folding result expressions that are
certainly unreachable --- the former coding was a bit cavalier about this
and could generate unexpected results for all-constant CASE expressions.
Add regression test cases. Per report from Vlad Marchenko.
|
|
* Update inet/cidr data types with newest Bind patches
|
|
|
|
tests. Contributed by Koju Iijima, review from Neil Conway, Gavin Sherry
and Tom Lane.
Also, fix error in description of WITH CHECK OPTION clause in the CREATE
VIEW reference page: it should be "CASCADED", not "CASCADE".
|
|
command counter more than necessary. Per report from Michael Fuhr.
|
|
estimate to less than the number of values estimated for any one grouping
Var, as suggested by Manfred. This is intuitively right, and what's
more it puts the plan choices in the subselect regression test back the
way they were before ...
|
|
initially NULL. For 8.0 we changed the main executor to have this
behavior in an UPDATE of an array column, but plpgsql's equivalent case
was overlooked. Per report from Sven Willenberger.
|
|
fix bug with inconsistent selection of default mask length for
"class D" addresses. Per report from Steve Atkins.
|
|
clamp the estimated number of groups to table row count over 10, instead
of table row count; this reflects a heuristic that people probably won't
group over a near-unique set of columns, and the knowledge that we don't
currently have any way to estimate the correlation of the columns better
than guessing. This change creates a trivial plan change in one of the
regression tests.
|
|
look at the actual aggregate transition datatypes and the actual overhead
needed by nodeAgg.c, instead of using pessimistic round numbers.
Per a discussion with Michael Tiemann.
|
|
defining List.
|
|
Solaris and should be a little faster anyway, since in most scenarios
all but perhaps the last path component will already exist.
|
|
functions of the aggregate, at both aggregate creation and execution times.
|
|
utils/cache/lsyscache.c where it can be used by other things. Also
cleans up both get_usesysid() and get_grosysid() a bit. From Stephen
Frost.
|
|
Relation. Patch from Alvaro Herrera, minor editorializing by
Neil Conway.
|
|
does not match what the query expected. From Brendan Jurd, minor
editorializing by Neil Conway.
|
|
command. This is useful because we can allow truncation of tables
referenced by foreign keys, so long as the referencing table is
truncated in the same command.
Alvaro Herrera
|
|
Tom.
|
|
to avoid problems when a cursor depends on objects created or changed in
the same subtransaction. We'd like to do better someday, but this seems
the only workable answer for 8.0.1.
|
|
it agrees with the default value of max_stack_depth.
|
|
column values in -d mode. Per report from Marty Scholes. This doesn't
completely solve the issue, because we still need multiple copies of the
field value, but at least one copy can be got rid of painlessly ...
|
|
when using stdout/stdin on Windows.
|
|
APPDATA directory on Windows. Magnus Hagander
|
|
Also clean up incredibly poor style in TocIDRequired() usage.
|
|
|
|
struct used in a typedef.
|
|
constraints on domain types are properly enforced, even if the newly
added column has no default value. Per bug #1433.
|
|
enforced properly when there is no explicit default value for the new
column. Per report from Craig Perras.
|
|
|
|
|
|
|
|
left input's sorting, because null rows may be inserted at various points.
Per report from Ferenc Lutischá¸n.
|
|
Lowercase some uppercase tags so tools is more reliable at finding
problems.
|
|
tablespace instead of the index's own), except when the index was created
as a constraint. Report and fix by Tanida Yutaka.
|
|
pre-7.3 pg_dump archive files: namespace isn't there, and in some cases
te->tag may already be quotified. Per report from Alan Pevec and
followup testing.
|
|
|
|
pass if "default_with_oids" is set to false. I took the approach of
explicitly adding WITH OIDS to the CREATE TABLEs where necessary, rather
than tweaking the default_with_oids GUC var.
|
